Skip to content

docs: add explicit skill discovery routing map - #19

Merged
pertrai1 merged 2 commits into
mainfrom
feat/explicit-skill-discovery
May 11, 2026
Merged

pertrai1 merged 2 commits into
mainfrom
feat/explicit-skill-discovery

Conversation

@pertrai1-bot

@pertrai1-bot pertrai1-bot commented May 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add an explicit Skill Discovery Map to directives/adaptive-routing.md
  • Make matched situations load canonical skill paths instead of relying on inference
  • Add a focused eval scenario for Debugging + Boundary skill selection

Verification

  • npm run check
  • git diff --check
  • npm run eval:scenario -- --print-only skill-discovery-map-routing

Summary by CodeRabbit

  • Documentation
    • Added "Skill Discovery Map" guidance to help select specialist skills after choosing a workflow path, mapping common situations and intents to required specialist skills.
    • Added a new test scenario specification for validating skill-discovery routing, defining expected routing behaviors, anti-behaviors, and quality criteria for selecting canonical specialist skills.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 11, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0dc11f33-962d-4aab-9eb9-22c49f018d02

📥 Commits

Reviewing files that changed from the base of the PR and between a3cf094 and fef58f4.

📒 Files selected for processing (1)
  • directives/adaptive-routing.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • directives/adaptive-routing.md

📝 Walkthrough

Walkthrough

Adds a "Skill Discovery Map" section to the adaptive-routing directive mapping situations/intents to workflow paths and canonical skills/**/SKILL.md files, and adds a new evaluation scenario that tests agent routing and explicit skill-loading behavior against that directive.

Changes

Skill Discovery Map Routing

Layer / File(s) Summary
Skill Discovery Map Directive
directives/adaptive-routing.md
New "Skill Discovery Map" section instructs loading all matching skills for matched situation/intent rows and includes a table mapping situations (exploration, implementation planning, debugging, review, test/spec review, boundary architecture review, codebase health, production readiness, self-audit) to workflow paths and canonical skills/**/SKILL.md references.
Routing Scenario Specification
evals/scenarios/skill-discovery-map-routing.md
New scenario spec: directive under test, setup constraint (directive loaded; no preloaded skills/*/SKILL.md), failing-test prompt to trigger routing, expected outcomes (select Debugging Path, load systematic-debugging skill, add Boundary Path and load architecture-boundary-reviewer and conditional test reviewer skills, report selected skills by canonical paths), listed anti-behaviors, and quality criteria enforcing exact canonical paths and explicit situation/intent triggers.

Sequence Diagram(s)

sequenceDiagram
  participant TestRunner
  participant AdaptiveRoutingDirective
  participant Agent
  participant SkillLoader
  participant SkillFiles
  TestRunner->>Agent: failing-test prompt (refactor-induced test failure)
  Agent->>AdaptiveRoutingDirective: request routing (situation/intent)
  AdaptiveRoutingDirective->>Agent: selected workflow path(s) (e.g., Debugging, Boundary)
  Agent->>SkillLoader: load skills for selected paths (canonical `skills/**/SKILL.md` list)
  SkillLoader->>SkillFiles: fetch `skills/systematic-debugging/SKILL.md`, `skills/architecture-boundary-reviewer/SKILL.md`, ...
  SkillLoader->>Agent: loaded skill modules
  Agent->>TestRunner: report routing results (named canonical skill paths)
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • pertrai1/agent-directives#4: Adds architecture-boundaries directive and related reviewer skills that map to canonical skill files referenced by the Skill Discovery Map.
  • pertrai1/agent-directives#9: Updates adaptive-routing rules and skill-to-workflow mappings, related to the routing logic changed here.
  • pertrai1/agent-directives#5: Modifies adaptive-routing workflow and skill-selection behavior; overlaps with the Skill Discovery Map additions.

Suggested reviewers

  • pertrai1
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'docs: add explicit skill discovery routing map' directly matches the main change: adding a Skill Discovery Map section to the adaptive-routing directive.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/explicit-skill-discovery

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an explicit “Skill Discovery Map” to the adaptive routing directive and a companion eval scenario to validate that routing selects canonical specialist skill paths based on explicit situation/intent matches (rather than inference).

Changes:

  • Document a Skill Discovery Map in directives/adaptive-routing.md to map common situations to required skill files.
  • Add a new eval scenario (skill-discovery-map-routing) to exercise Debugging + Boundary skill selection behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
evals/scenarios/skill-discovery-map-routing.md Adds an eval scenario asserting Debugging + Boundary skill selection and canonical skill-path disclosure.
directives/adaptive-routing.md Introduces a Skill Discovery Map table mapping situations/intents to required specialist skill files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread directives/adaptive-routing.md Outdated
Comment on lines +100 to +101
| Vague feature idea, product request, or unclear requirement needs a PRD/spec | Exploration | `skills/product-requirements-writer/SKILL.md` |
| PRD, issue, spec, or acceptance criteria needs implementation tasks | Exploration | `skills/implementation-task-planner/SKILL.md` |
Comment thread directives/adaptive-routing.md Outdated
| Reviewing a PR, branch, diff, or local changes | Review | `skills/code-reviewer/SKILL.md` |
| Writing, changing, or reviewing tests/eval scenarios | Full / Review | `skills/test-reviewer/SKILL.md` |
| Implementation must be checked against a written spec/PRD | Full / Review | `skills/spec-reviewer/SKILL.md` |
| Imports, exports, package boundaries, folders, services, shared utilities, or dependency direction change | Boundary | `skills/architecture-boundary-reviewer/SKILL.md` |
Comment thread directives/adaptive-routing.md Outdated
| Implementation must be checked against a written spec/PRD | Full / Review | `skills/spec-reviewer/SKILL.md` |
| Imports, exports, package boundaries, folders, services, shared utilities, or dependency direction change | Boundary | `skills/architecture-boundary-reviewer/SKILL.md` |
| TypeScript/JavaScript refactor, cleanup, shared utilities, dead-code, duplication, complexity, or static-analysis health concern | Full / Review | `skills/codebase-health-reviewer/SKILL.md` |
| Persistence, external services, async jobs, auth/security/privacy, infra/config/deploy, critical user paths, performance/scale, or cross-service compatibility | Full / Review | `skills/production-readiness-reviewer/SKILL.md` |
@pertrai1-bot

Copy link
Copy Markdown
Collaborator Author

Review feedback addressed

Reviewed Copilot's 3 inline comments and found all were valid consistency issues in the new Skill Discovery Map:

  • Expanded PRD/spec and implementation-task rows to Exploration / Full / Policy to match skill routing metadata and Full Path usage.
  • Expanded architecture-boundary reviewer row to Boundary / Review.
  • Expanded production-readiness reviewer row to Full / Debugging / Review.
  • Renamed Path to Common path(s) and clarified that the column is not a filter; matched situations still load the skill when paths are combined or escalated.

Verification

  • npm run check
  • git diff --check
  • npm run eval:scenario -- --print-only skill-discovery-map-routing

@pertrai1
pertrai1 merged commit 695f2e9 into main May 11, 2026
1 check passed
@pertrai1
pertrai1 deleted the feat/explicit-skill-discovery branch May 11, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants