Fix datetime filters against numeric parameters
#3081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Stein <steinlink@gmail.com>
texodus
changed the title
datetime filters against number parametersdatetime filters against numeric parameters
texodus
requested review from
tomjakubowski
and removed request for
sinistersnare
tomjakubowski
approved these changes
Nov 4, 2025
Contributor
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an integer overflow bug when a numeric type is used as a parameter for a
"datetime"column filter in aViewConfig, and corrects a few tests which should have caught this condition but were themselves bugged during the port to3.x.