Fix workspace special casing issue #3066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbess
force-pushed
the
bugfix/workspace-global-filter-fix
branch
from
2c4a6c7 to
919e807
Compare
timbess
force-pushed
the
bugfix/workspace-global-filter-fix
branch
3 times, most recently
from
bf0efcb to
e4530d3
Compare
This fixes the special case for datagrids by forcing plugins to use perspective-select events rather than attempting to handle both click and selects. This also fixes some issues with global filtering on datagrids where selections overlapped with collapsing/expanding rows. Signed-off-by: Timothy Bess <timbessmail@gmail.com>
timbess
force-pushed
the
bugfix/workspace-global-filter-fix
branch
from
e4530d3 to
ab31703
Compare
texodus
approved these changes
Oct 29, 2025
|
|
||
| if ( | ||
| event.type === "perspective-click" && | ||
| (config.plugin === "Datagrid" || config.plugin === null) |
Contributor
|
@timbess In v4.0.1 I can no longer click on a global filter row group to collapse/expand it, it always selects it, is that intended? See: https://perspective-dev.github.io/block/?example=nypd, Incidents by Allegation, clicking on any allegation selects its subrows but doesn't collapse it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes special case in workspace for
Datagrids that allowed bothclickandselectevents to be treated as global filter selections unless the plugin is named"Datagrid".Pull Request Checklist
Discussions, this PR applies to.