Fix Workspace.removeTable() #3048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Jakubowski <tom@prospective.dev>
tomjakubowski
commented
Aug 28, 2025
| } | ||
|
|
||
| delete(name: K) { | ||
| const result = this._delete_listener?.(name); |
Contributor
Author
There was a problem hiding this comment.
The delete listener registered by the workspace always returns undefined now, so this ended up always taking the else branch below, which skips removing the key from the map. It looks like the delete listener is not meant anymore to prevent deletes, and the workspace is the only user of this module, so I removed the conditional entirely.
The ObservableMap's delete listener used to be able to "reject" deletions by returning false. This is no longer the case; the listener in Workspace always returns undefined now. Account for this in observable map's delete method. Co-authored-by: Davis Silverman <davis@prospective.dev> Signed-off-by: Tom Jakubowski <tom@prospective.dev>
tomjakubowski
force-pushed
the
bugfix/workspace-remove-table
branch
from
afe0dfd to
8a5b6bb
Compare
texodus
approved these changes
Sep 1, 2025
Member
texodus
left a comment
texodus
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to the workspace/viewer error handling resulted in the workspace
removeTable() method always failing. This fixes the bug and adds a smoke/regression
test.
Also includes a Typescript fix for types in the custom elements registry.