add a test repro for a "View not found" error #3039
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinistersnare
force-pushed
the
bugfix/view-not-found-load-timing
branch
3 times, most recently
from
d9e929e to
2815d54
Compare
Signed-off-by: Davis Silverman <davis@prospective.dev>
sinistersnare
force-pushed
the
bugfix/view-not-found-load-timing
branch
from
2815d54 to
eecbe7f
Compare
Member
|
Closing in favor of #3045 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This is a repro for a bug that I have been experiencing working on some other stuff in Perspective.
Perspective regularly conflates and squashes messages that are out of date, and it does this by using the exception mechanism (With a message "View not found") to signal such an event has occurred. However, this repro shows a place where this message is presented to the user instead of being swallowed by the engine. A proper fix will end up hiding this message as is expected.