Skip to content

Conversation

@texodus
Copy link
Member

@texodus texodus commented Jun 14, 2025

  • Adds id, className and a few other pass-through attributes for @finos/perspective-react. Perspective's props cannot inherit from React.HTMLAttributes due to conflicting definitions for onClick and onSelect, which I do not feel like resolving in this release (and many HTML attributes are not directly applicable to <perspective-viewer> anyway).

  • Adds new static accessors for Perspecitve Custom Elements max_cells and max_columns render limits flags, and adds tests and docs for render limits configuration, e.g.:

    customElements.get("perspective-viewer-d3fc-treemap").max_cells = 1_000_000;

    or

    for (const plugin of await document.querySelector("perspective-viewer").getAllPlugins()) {
        if (plugin.name === "Treemap") {
            plugin.max_columns = 1_000;
        }
    }
  • Adds data-x and data-y dataset attributes to @finos/perspective-viewer-datagrid's internal table rendering, such that CSS rules may be made aware of the table's virtual dimensions.

  • Port all UI elements Custom Elements implementations to use adoptedStyleSheets rather than inline <style> tags, which offers both a widget-load-performance boost as well as a simpler mechanism for extending Perspective' internal style rules.

  • Update's the test suite to allow finer-grained debugging for large HTML diffs.

@texodus texodus added the enhancement Feature requests or improvements label Jun 14, 2025
Signed-off-by: Andrew Stein <steinlink@gmail.com>
@texodus texodus force-pushed the react-api-2 branch 2 times, most recently from 9940c3f to 99797fb Compare June 19, 2025 01:35
Signed-off-by: Andrew Stein <steinlink@gmail.com>
@texodus texodus force-pushed the react-api-2 branch 2 times, most recently from 33c4a67 to 556d3ab Compare June 19, 2025 02:31
Signed-off-by: Andrew Stein <steinlink@gmail.com>
@texodus texodus force-pushed the react-api-2 branch 2 times, most recently from 1e0f90e to 1066773 Compare June 19, 2025 16:26
texodus added 2 commits June 19, 2025 14:41
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
@texodus texodus marked this pull request as ready for review June 19, 2025 20:00
@texodus texodus merged commit da1e971 into master Jun 19, 2025
14 checks passed
@texodus texodus deleted the react-api-2 branch June 19, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature requests or improvements

Development

Successfully merging this pull request may close these issues.

2 participants