New error UX #3003
Merged
New error UX #3003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
new-error-ux
branch
3 times, most recently
from
f098de8 to
7296b5a
Compare
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new UX for capturing the error details on hover over the error status icon. Additionally, the
perspective_js::ApiErrorerror type has been upgraded tothiserrorderived version, in order to support the new UX features:String -> Rich error type -> String -> Rich error type -> ...conversions flattened to useApiErroreverywhere.ClientError/ApiErrorforClient::on_errorcallbacks, which is an API breaking change (though this type implementsDisplayalso).