load urdf/srdf from json-wrapped string input #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2016
|
|
||
| /** Constructs plugin and registers functions */ | ||
| URDFLoader(OpenRAVE::EnvironmentBasePtr env) : OpenRAVE::ModuleBase(env) | ||
| { | ||
| __description = "URDFLoader: Loader that imports URDF files."; | ||
| _env = env; | ||
|
|
||
| RegisterCommand("load", boost::bind(&URDFLoader::load, this, _1, _2), | ||
| RegisterCommand("load", boost::bind(&URDFLoader::loadFile, this, _1, _2), |
There was a problem hiding this comment.
This looks great, but I think the names are now confusing. I proposed that we (a) rename URDFLoader::load -> URDFLoader::loadModel, (b) rename URDFLoader::loadFile -> URDFLoader::loadURI and rename its command registration to LoadURI, and (c) create a new wrapper command called URDFLoader::load registered as Load which internally forwards to LoadURI (perhaps eventually with a deprecation warning?). What do y'all think?
There was a problem hiding this comment.
I agree with @cdellin. Lets:
- Rename
URDFLoader::loadtoURDFLoader::loadModel. - Rename
URDFLoader::loadFiletoURDFLoader::loadURI. - Rename the
Loadcommand toLoadURI. - Rename the
LoadJsonStringcommand toLoadString. - Add a
Loadcommand that prints a deprecation warning and forwards toLoadURI.
|
If we are shoving a random header-only JSON library in here, I prefer https://github.com/nlohmann/json to |
|
👍 I'll merge once Travis is happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards-compatible with previous interface, this adds additional ability to load a urdf and (optionally) srdf from a json-wrapped string through OpenRAVE plugin command.