Skip to content

fix: fix default home path, so it always picks from client #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2025
Merged

fix: fix default home path, so it always picks from client #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0ffc21
fix default home path, so it always picks from client
puneet2019 Aug 28, 2025
e93c351
add temp dir which can be written and deleted after tempapp usage
puneet2019 Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,18 @@
package app

import (
"cosmossdk.io/client/v2/autocli"
"cosmossdk.io/core/appmodule"
"encoding/json"
"fmt"
"github.com/cosmos/cosmos-sdk/codec/address"
"io"
stdlog "log"
"os"
"path/filepath"
"reflect"
"strings"

"cosmossdk.io/client/v2/autocli"
clienthelpers "cosmossdk.io/client/v2/helpers"
"cosmossdk.io/core/appmodule"
"github.com/cosmos/cosmos-sdk/codec/address"

autocliv1 "cosmossdk.io/api/cosmos/autocli/v1"
reflectionv1 "cosmossdk.io/api/cosmos/reflection/v1"
"cosmossdk.io/log"
Expand Down Expand Up @@ -75,12 +75,11 @@ var (
)

func init() {
userHomeDir, err := os.UserHomeDir()
var err error
DefaultNodeHome, err = clienthelpers.GetNodeHomeDirectory(".persistenceCore")
if err != nil {
stdlog.Println("Failed to get home dir %2", err)
panic(err)
}

DefaultNodeHome = filepath.Join(userHomeDir, ".persistenceCore")
}

type Application struct {
Expand Down
28 changes: 25 additions & 3 deletions cmd/persistenceCore/cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import (
"io"
"os"

"github.com/cosmos/cosmos-sdk/client"
"github.com/cosmos/cosmos-sdk/client/snapshot"
"github.com/cosmos/cosmos-sdk/testutil/sims"
"github.com/persistenceOne/persistenceCore/v13/app/constants"

"cosmossdk.io/log"
Expand All @@ -16,7 +16,6 @@ import (
cmtcfg "github.com/cometbft/cometbft/config"
cmtcli "github.com/cometbft/cometbft/libs/cli"
dbm "github.com/cosmos/cosmos-db"
"github.com/cosmos/cosmos-sdk/client"
"github.com/cosmos/cosmos-sdk/client/config"
"github.com/cosmos/cosmos-sdk/client/debug"
"github.com/cosmos/cosmos-sdk/client/flags"
Expand All @@ -26,6 +25,7 @@ import (
"github.com/cosmos/cosmos-sdk/server"
serverconfig "github.com/cosmos/cosmos-sdk/server/config"
servertypes "github.com/cosmos/cosmos-sdk/server/types"
simtestutil "github.com/cosmos/cosmos-sdk/testutil/sims"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/version"
authcmd "github.com/cosmos/cosmos-sdk/x/auth/client/cli"
Expand Down Expand Up @@ -60,7 +60,19 @@ func NewRootCmd() (*cobra.Command, params.EncodingConfig) {
WithHomeDir(app.DefaultNodeHome).
WithViper("")

tempApp := app.NewApplication(log.NewNopLogger(), dbm.NewMemDB(), nil, true, sims.EmptyAppOptions{}, []wasm.Option{})
tempDir := tempDir()
tempApp := app.NewApplication(log.NewNopLogger(), dbm.NewMemDB(), nil, true, simtestutil.NewAppOptionsWithFlagHome(tempDir), []wasm.Option{})
defer func() {
if err := tempApp.Close(); err != nil {
panic(err)
}
if tempDir != app.DefaultNodeHome {
err := os.RemoveAll(tempDir)
if err != nil {
panic(err)
}
}
}()

cobra.EnableCommandSorting = false

Expand Down Expand Up @@ -295,3 +307,13 @@ func appExport(

return persistenceApp.ExportAppStateAndValidators(forZeroHeight, jailAllowedAddrs, modulesToExport)
}

// tempDir create a temporary directory to initialize the command line client
func tempDir() string {
dir, err := os.MkdirTemp("", "persistenceCore")
if err != nil {
panic("failed to create temp dir: " + err.Error())
}

return dir
}
Loading