[BUGFIX] Prometheus: Fix notch in Prometheus Datasource Select#73
Merged
andreasgerstmayr merged 3 commits intoperses:mainfrom Mar 19, 2025
Merged
Conversation
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Member
|
I guess the same fix should be done for Tempo :) |
6 tasks
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Contributor
Author
I thought initially I create a separate PR for Tempo, but the change is small enough, so I added it here now :) |
Member
|
With the Perses release, you should be good here to update. |
…ce-select-fix-notch
Nexucis
approved these changes
Mar 18, 2025
Member
Nexucis
left a comment
Nexucis
left a comment
There was a problem hiding this comment.
nice fix !
As a side note, I don't know if someone noticed, but there is a lot of warning in the build:
File: /home/runner/work/plugins/plugins/node_modules/@perses-dev/components/dist/Legend/Legend.js:1:1
⚠ No required version specified and unable to automatically determine one. Unable to find required version for "immer" in description file/s
│ /home/runner/work/plugins/plugins/package.json
│ /home/runner/work/plugins/plugins/node_modules/@perses-dev/components/package.json
│ It need to be in dependencies, devDependencies or peerDependencies. file: shared module immer
@ ../node_modules/@perses-dev/components/dist/Legend/index.js
@ ../node_modules/@perses-dev/components/dist/index.js
@ consume shared module (default) @perses-dev/components@^0.51.0-beta.0 (strict) (fallback: /home/runner/work/plugins/plugins/node_modules/@perses-dev/components/dist/index.js)
@ ./src/BarChartOptionsEditorSettings.tsx
@ ./src/BarChart.ts
@ container entry
File: /home/runner/work/plugins/plugins/node_modules/@perses-dev/components/dist/ThresholdsEditor/ThresholdsEditor.js:1:1
⚠ No required version specified and unable to automatically determine one. Unable to find required version for "immer" in description file/s
│ /home/runner/work/plugins/plugins/node_modules/@perses-dev/components/package.json
│ /home/runner/work/plugins/plugins/package.json
│ It need to be in dependencies, devDependencies or peerDependencies. file: shared module immer
@ ../node_modules/@perses-dev/components/dist/ThresholdsEditor/index.js
@ ../node_modules/@perses-dev/components/dist/index.js
@ consume shared module (default) @perses-dev/components@^0.51.0-beta.0 (strict) (fallback: /home/runner/work/plugins/plugins/node_modules/@perses-dev/components/dist/index.js)
@ ./src/BarChartOptionsEditorSettings.tsx
@ ./src/BarChart.ts
@ container entry
File: /home/runner/work/plugins/plugins/node_modules/@perses-dev/plugin-system/dist/remote/PluginRuntime.js:1:1
⚠ No required version specified and unable to automatically determine one. Unable to find required version for "@emotion/styled" in description file/s
│ /home/runner/work/plugins/plugins/node_modules/@perses-dev/plugin-system/package.json
│ /home/runner/work/plugins/plugins/package.json
│ It need to be in dependencies, devDependencies or peerDependencies. file: shared module @emotion/styled
@ ../node_modules/@perses-dev/plugin-system/dist/remote/remotePluginLoader.js
@ ../node_modules/@perses-dev/plugin-system/dist/remote/index.js
@ ../node_modules/@perses-dev/plugin-system/dist/index.js
@ consume shared module (default) @perses-dev/plugin-system@^0.51.0-beta.0 (strict) (fallback: /home/runner/work/plugins/plugins/node_modules/@perses-dev/plugin-system/dist/index.js)
@ ./src/BarChartOptionsEditorSettings.tsx
@ ./src/BarChart.ts
@ container entry
File: /home/runner/work/plugins/plugins/node_modules/@perses-dev/plugin-system/dist/remote/PluginRuntime.js:1:1
⚠ No required version specified and unable to automatically determine one. Unable to find required version for "lodash" in description file/s
│ /home/runner/work/plugins/plugins/node_modules/@perses-dev/plugin-system/package.json
│ /home/runner/work/plugins/plugins/package.json
│ It need to be in dependencies, devDependencies or peerDependencies. file: shared module lodash
@ ../node_modules/@perses-dev/plugin-system/dist/remote/remotePluginLoader.js
@ ../node_modules/@perses-dev/plugin-system/dist/remote/index.js
@ ../node_modules/@perses-dev/plugin-system/dist/index.js
@ consume shared module (default) @perses-dev/plugin-system@^0.51.0-beta.0 (strict) (fallback: /home/runner/work/plugins/plugins/node_modules/@perses-dev/plugin-system/dist/index.js)
@ ./src/BarChartOptionsEditorSettings.tsx
@ ./src/BarChart.ts
@ container entry
File: /home/runner/work/plugins/plugins/node_modules/@perses-dev/plugin-system/dist/remote/PluginRuntime.js:1:1
⚠ No required version specified and unable to automatically determine one. Unable to find required version for "date-fns-tz" in description file/s
│ /home/runner/work/plugins/plugins/package.json
│ /home/runner/work/plugins/plugins/node_modules/@perses-dev/plugin-system/package.json
│ It need to be in dependencies, devDependencies or peerDependencies. file: shared module date-fns-tz
@ ../node_modules/@perses-dev/plugin-system/dist/remote/remotePluginLoader.js
@ ../node_modules/@perses-dev/plugin-system/dist/remote/index.js
@ ../node_modules/@perses-dev/plugin-system/dist/index.js
@ consume shared module (default) @perses-dev/plugin-system@^0.51.0-beta.0 (strict) (fallback: /home/runner/work/plugins/plugins/node_modules/@perses-dev/plugin-system/dist/index.js)
@ ./src/BarChartOptionsEditorSettings.tsx
@ ./src/BarChart.ts
@ container entry
File: /home/runner/work/plugins/plugins/node_modules/@perses-dev/plugin-system/dist/remote/PluginRuntime.js:1:1
⚠ No required version specified and unable to automatically determine one. Unable to find required version for "echarts" in description file/s
│ /home/runner/work/plugins/plugins/package.json
│ /home/runner/work/plugins/plugins/node_modules/@perses-dev/plugin-system/package.json
│ It need to be in dependencies, devDependencies or peerDependencies. file: shared module echarts
@ ../node_modules/@perses-dev/plugin-system/dist/remote/remotePluginLoader.js
@ ../node_modules/@perses-dev/plugin-system/dist/remote/index.js
@ ../node_modules/@perses-dev/plugin-system/dist/index.js
@ consume shared module (default) @perses-dev/plugin-system@^0.51.0-beta.0 (strict) (fallback: /home/runner/work/plugins/plugins/node_modules/@perses-dev/plugin-system/dist/index.js)
@ ./src/BarChartOptionsEditorSettings.tsx
@ ./src/BarChart.ts
@ container entry
Contributor
Author
|
I've created #92 for the module federation warnings. |
coleenquadros
pushed a commit
to coleenquadros/plugins
that referenced
this pull request
Jul 9, 2025
Add dashboard for Kube Controller Manager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MUI
<FormControl>usually detects if the<Select>child component is filled, and shrinks and adds a notch to the Select to place the label. However, this only works if the child component is a MUI component: https://github.com/mui/material-ui/blob/4c3f5179a9edd778a1cc0e8457034e5109d66f7f/packages/mui-material/src/FormControl/FormControl.js#L149-L164In our case, the child is a
<DatasourceSelect>, and this algorithm doesn't work, it doesn't add the notch and doesn't shrink the label, i.e. the label now overlaps the selected value:This can be fixed by explicitly setting
shrinkon the<InputLabel>andnotchedon the<Select>:Requires perses/perses#2731 to be merged first.