[IGNORE] add snyk workflow to regenerate lockfile#222
Conversation
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
| run: | | ||
| echo "message=$(git log -1 --pretty=%s)" >> $GITHUB_OUTPUT | ||
|
|
||
| - uses: stefanzweifel/git-auto-commit-action@v6 |
There was a problem hiding this comment.
I would avoid any 3rd-party GitHub action in our CI to avoid any possible pipeline compromise.
There was a problem hiding this comment.
(use the regular git cli, or gh)
|
I'm surprised that snyk creates broken PRs, maybe it has a setting somewhere to regenerate the lockfile? |
I was too. But it seems workspaces are not fully supported... Or we ar missing to check a checkbox: https://docs.snyk.io/supported-languages-package-managers-and-frameworks/javascript/git-repositories-and-javascript |
|
Recent PRs update the lockfile now: perses/perses#3152 However, the DCO check still fails. As the snyk bot is required by CNCF, and the DCO bot also (I guess), there should be a simple solution for that (configure the DCO bot to ignore snyk commits, or configure the snyk bot to add a commit sign-off). |
Description
This PR creates a new GitHub workflow to allow to regenerate the lockfile when a PR is coming from a snyk branch. It amends the commit with DCO signing and the package-lock.json file changes.
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.