fix(item): allow nested content to be conditionally interactive #2
+43
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves ionic-team#29763
What is the current behavior?
In Angular, if the nested content of an ion-item is initially not interactive but is then swapped out for an input or other interactive element, a render is not triggered and the item does not behave correctly for one or more nested inputs.
What is the new behavior?
-A mutation observer is used to watch for changes in nested content and reset two pieces of state that track whether the item needs to be interactive and whether there are multiple interactive elements.
Does this introduce a breaking change?
Other information
A MutationObserver is used so that if the children of the item are rendered conditionally, when they are swapped out the component checks again to determine whether the item needs to gain or lose interactivity and updates state accordingly, causing a render if isInteractive or multipleInputs changes state. I opted for the MutationObserver over a 'slotchange' listener because the slotchange fires synchronously on any slot within the shadowRoot, and the MutationObserver fires once.