Correctly calculate byte size of the utf8 strings #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation started causing problems when the webdav client was used in combination with axios 0.22 and later, as in 0.22 axios started considering the `Content-Length` passed in the request axios/axios@f3ca637#diff-586c04c24608b86a074073c5514cc195be5c4c87ddb56da233f6d998ada4159fL85 where it previously ignored it and calculated the length on its own.
perry-mitchell
requested changes
Feb 25, 2022
| @@ -9,7 +9,7 @@ export function calculateDataLength(data: string | BufferLike): number { | |||
| } else if (isBuffer(data)) { | |||
| return (<Buffer>data).length; | |||
| } else if (typeof data === "string") { | |||
| return (<string>data).length; | |||
| return Buffer.byteLength(<string>data); | |||
There was a problem hiding this comment.
Unfortunately this won't work, as Buffer is not available in the web build.
|
Seeing as I didn't get any response, I'll merge and modify this fix to use a library which covers byte-size calculations. |
perry-mitchell
added a commit
that referenced
this pull request
May 16, 2022
|
Hi. Sorry for not responding. I stopped hoping that this could go live as is, so I've given up. Thanks for taking the extra step to make it compatible with browser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation started causing problems when the webdav client was used in combination with axios 0.22 and later, as in 0.22 axios started considering the
Content-Lengthpassed in the request where it previously ignored it and calculated the length on its own.