Open
Conversation
Contributor
Author
|
aca948e the last one here is a pointer to how I think this should go, but I wanted to see about the print capture.... |
Contributor
Author
|
Note that the race condition here is visible also if you run multiple concurrent copies of papers under separate interpreters. |
Contributor
Author
|
OK, this does have a test that does work on the existing test files and is the bare minimum of quality control, but I'd be glad for a pointer to a better way of doing that print capture. Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
papers extract thing.pdfis wonderful for checking that the DOI/crossref call on a single PDF is going to make sense.This PR enables the same behavior on a whole directory recursively, much like
papers add --recursive.@perrette I need a pointer on how to write good tests for this one -- I was playing with
test/test_extract.pybut can't figure out how to capture printed output to compare to the database of the two test files you have -- much like intests/test_add.py