Add Sidecar routes for the new rego rules - #95
Merged
Conversation
omer9564
marked this pull request as ready for review
September 7, 2023 08:06
omer9564
force-pushed
the
omer/per-7812-sidecar-routes
branch
from
September 7, 2023 08:08
b112f1e to
532364c
Compare
shaulk
approved these changes
Sep 7, 2023
shaulk
left a comment
shaulk
left a comment
Contributor
There was a problem hiding this comment.
Approved with some suggestions. Also, we now build the sidecar with Python 3.10 so you can use new-style annotations.
omer9564
force-pushed
the
omer/per-7812-sidecar-routes
branch
3 times, most recently
from
September 10, 2023 08:46
e16ac96 to
0029356
Compare
omer9564
force-pushed
the
omer/per-7812-sidecar-routes
branch
from
September 10, 2023 09:00
0029356 to
8525bc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.