Per 12446 add unassign role to consistent updates #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `FactsClient` to support optional query parameters in `build_forward_request` and `send_forward_request` methods, improving flexibility in request handling. - Added new DELETE endpoints for unassigning user roles and deleting role assignments in the `facts_router`, allowing for better management of user roles with a `return_deleted` query parameter. - Refactored `forward_request_then_wait_for_update` to accommodate the new query parameters, ensuring consistent behavior across requests.
- Updated `build_forward_request` and `send_forward_request` methods in `FactsClient` to eliminate the optional `query_params` argument, simplifying the request handling process. - Adjusted related calls in `facts_router` to align with the new method signatures, ensuring consistent behavior across the application.
omer9564
force-pushed
the
per-12446-add-unassign-role-to-consistent-updates
branch
from
4fada88 to
bd1b306
Compare
danyi1212
approved these changes
Jun 22, 2025
- Updated `FactsClient` methods to accept optional `query_params`, improving flexibility in request handling. - Introduced a `pre_return_callback` parameter to `convert_response` for custom response processing. - Modified `facts_router` endpoints to utilize the new query parameter functionality, specifically for handling `return_deleted` logic in user role management. - Added a utility function to convert 200 responses to 204, enhancing response consistency.
danyi1212
reviewed
Jun 23, 2025
- Eliminated the `pre_return_callback` parameter from `convert_response` in `FactsClient`, simplifying response handling. - Updated `unassign_user_role` and `delete_role_assignment` functions in `facts_router` to remove references to `pre_return_callback`, ensuring consistent response processing. - Adjusted `forward_request_then_wait_for_update` to align with the new method signature, enhancing clarity and maintainability.
- Updated the `FactsClient` to use a separate variable for merging query parameters, improving code clarity. - Simplified the request parameter construction by directly using the new variable, enhancing maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.