fix(services/version): prevent checkForUpdate() 5xx response codes from stopping connection #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was receiving this error earlier today and couldn't connect to my process:
I found the issue was around the response code returned from fetching from
UPDATE_URL
(value ishttps://get_ao.g8way.io
) for an update. The response code was502
.Although this PR doesn't address every edge case, it addresses the one I experienced earlier today. This PR introduces the following:
{ available: false }
if fetching from update URL returns a 5xx status code{ available: false }
process.env.DEBUG
is truthy, a warning message will be shown for fetches that result in 5xx status codes. For example: