bug(connect): message creating invalid DataItems when used in Deno due to arweave-js crypto usage.

[leeduckgo]

Example Code, it ran well in node but not in deno.

import { dryrun, message, createDataItemSigner } from "https://esm.sh/@permaweb/aoconnect@0.0.58";
// import Arweave from "npm:arweave@1.15.1";
import Arweave from "https://esm.sh/arweave@1.15.1";

const arweave = Arweave.init({
    host: 'arweave.net',
    port: 443,
    protocol: 'https'
  });

const wallet = await arweave.wallets.generate();
console.log(wallet);

// The only 2 mandatory parameters here are process and signer
await message({
  /*
    The arweave TXID of the process, this will become the "target".
    This is the process the message is ultimately sent to.
  */
  process: "Rijbx6FduUMdCZM0tJ4PPxXljUNy1m0u_kmMIFGFM5c",
  // Tags that the process will use as input.
  tags: [{ name: "Action", value: "AddNew" }],
  // A signer function used to build the message "signature"
  signer: createDataItemSigner(wallet),
  /*
    The "data" portion of the message
    If not specified a random string will be generated
  */
  data: "data",
})
  .then(console.log)
  .catch(console.error);

Run Command:
deno run --allow-read --allow-write --allow-net --unstable-kv --unstable-cron -A ./test.js

Error Msg:

[TillaTheHun0]

Hey @leeduckgo . Sorry you're seeing issues.

We've definitely used aoconnect in Deno:

import { dryrun } from 'npm:@permaweb/aoconnect'

dryrun({
  process: 'Rijbx6FduUMdCZM0tJ4PPxXljUNy1m0u_kmMIFGFM5c',
  Owner: 'h8WzXOG1leDquKyNfHzCh0zW7FfDyN7qxLnZgXzPDGk',
  tags: [
    { name: 'Action', value: 'Eval' }
  ],
  data: '1 + 1'
})
  .then(console.log)
  .catch(console.error)

Perhaps esm.sh is polyfilling something incorrectly? Is it possible to import from npm? aoconnect is an ES6 module, and has minimal dependencies, so Deno node-compat impact should be minimal.

[leeduckgo]

Hey @leeduckgo . Sorry you're seeing issues.

We've definitely used aoconnect in Deno:

import { dryrun } from 'npm:@permaweb/aoconnect'

dryrun({
  process: 'Rijbx6FduUMdCZM0tJ4PPxXljUNy1m0u_kmMIFGFM5c',
  Owner: 'h8WzXOG1leDquKyNfHzCh0zW7FfDyN7qxLnZgXzPDGk',
  tags: [
    { name: 'Action', value: 'Eval' }
  ],
  data: '1 + 1'
})
  .then(console.log)
  .catch(console.error)

Perhaps esm.sh is polyfilling something incorrectly? Is it possible to import from npm? aoconnect is an ES6 module, and has minimal dependencies, so Deno node-compat impact should be minimal.

import { dryrun, message, createDataItemSigner } from "npm:@permaweb/aoconnect@0.0.58";
// import Arweave from "npm:arweave@1.15.1";
import Arweave from "https://esm.sh/arweave@1.15.1";


const arweave = Arweave.init({
    host: 'arweave.net',
    port: 443,
    protocol: 'https'
  });

const wallet = await arweave.wallets.generate();
console.log(wallet);

// The only 2 mandatory parameters here are process and signer
await message({
  /*
    The arweave TXID of the process, this will become the "target".
    This is the process the message is ultimately sent to.
  */
  process: "Rijbx6FduUMdCZM0tJ4PPxXljUNy1m0u_kmMIFGFM5c",
  // Tags that the process will use as input.
  tags: [{ name: "Action", value: "AddNew" }],
  // A signer function used to build the message "signature"
  signer: createDataItemSigner(wallet),
  /*
    The "data" portion of the message
    If not specified a random string will be generated
  */
  data: "data",
})
  .then(console.log)
  .catch(console.error);

  dryrun({
    process: 'Rijbx6FduUMdCZM0tJ4PPxXljUNy1m0u_kmMIFGFM5c',
    Owner: 'h8WzXOG1leDquKyNfHzCh0zW7FfDyN7qxLnZgXzPDGk',
    tags: [
      { name: 'Action', value: 'Eval' }
    ],
    data: '1 + 1'
  })
    .then(console.log)
    .catch(console.error)

Yep, I tried npm: at first, but it's not working too so I tried esm in the second time.

The dryrun is fine, so I think that there maybe some problem in createDataItemSigner(wallet).

[leeduckgo]

[DevChanQ]

Facing the same problem here. Dry running works fine but sending messages returns error 422

[TillaTheHun0]

Thanks @leeduckgo @DevChanQ . Sounds like there is an issue when creating and signing the data item, and so the MU is responding with a 422 Unprocessable Entity.

This is most likely something to do with Deno's node compat layer, as createDataItemSigner provided OOTB with aoconnect uses node crypto and is probably breaking somewhere. This will need further investigation.

FWIW, aoconnect allows for implementing your own data item signer. That is a potential workaround for Deno until this issue can be investigated.

[twilson63]

This is the issue: ArweaveTeam/arweave-js#223 If someone wants to resolve, it will unlock being able to sign dataItems in non-node environments Thx Tom

…

On Thu, Aug 15, 2024 at 9:19 AM Tyler Hall ***@***.***> wrote: Thanks @leeduckgo <https://github.com/leeduckgo> @DevChanQ <https://github.com/DevChanQ> . Sounds like there is an issue when creating and signing the data item, and so the MU is responding with a 422 Unprocessable Entity. This is most likely something to do with Deno's node compat layer, as createDataItemSigner provided OOTB with aoconnect uses node crypto and is probably breaking somewhere. This will need further investigation. FWIW, aoconnect allows for implementing your own data item signer <https://github.com/permaweb/ao/tree/main/connect#createdataitemsigner>. That is a potential workaround for Deno until this issue can be investigated. — Reply to this email directly, view it on GitHub <#953 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFGLECFFHPPVFWXXRTTG3ZRSTH7AVCNFSM6AAAAABMIKEVSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGI2TKMRWGU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[DevChanQ]

Managed to put together a solution that works within the Deno runtime by leveraging the Deno standard crypto module as the crypto driver. Since the standard crypto module implements the WebCrypto API, I was able to adapt the webcrypto driver implementation from here and have it use the Deno standard crypto module.

Until the compatibility issues with Deno’s node crypto module are resolved, this approach seems to be the best alternative. Appreciate any feedback or suggestions you might have!

Repo: https://github.com/DevChanQ/ao-deno-test
Try it out here: https://devjeff-ao-deno-tes-95.deno.dev/