fix some queries with columns beginning with limit would fail
#349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pali
added a commit
to pali/DBD-MariaDB
that referenced
this pull request
Sep 8, 2023
Tests are modified from the pull request perl5-dbi/DBD-mysql#349 done by kebhr.
Contributor
Author
|
@dveeden Hello. Could you please take a look at this pull-request when you have a moment? |
Contributor
|
This seems ripe for merging - it has tests for the additional behaviour? |
dveeden
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#288 fixes a problem in which SQL involving columns whose names end in
limitcannot be generated successfully.However, this fix caused SQL containing columns starting with
limitto fail to generate successfully (e.g.SELECT * FROM table WHERE limit_by > ?).This is because the syntax interpretation compares it to
limitwhen it should be compared tolimitwhich includes white space.I have created a fix for this problem and a test code that can confirm this issue.
With 4.050, modified t/35limit.t fails, but when this pull request is applied, it succeeds.