Use abi.encodePacked instead of string.concat (#18)

perimetersec · Mar 25, 2024 · 6fc7c62 · 6fc7c62
1 parent 5a39dee
commit 6fc7c62
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/src/AssertHelper.sol b/src/AssertHelper.sol
@@ -331,7 +331,10 @@ abstract contract AssertHelper {
     ) internal {
         bool isEqual = FuzzLibString.isRevertReasonEqual(returnData, reason1) ||
             FuzzLibString.isRevertReasonEqual(returnData, reason2);
-        assertWithMsg(isEqual, string.concat(reason1, " OR ", reason2));
+        string memory assertMsg = string(
+            abi.encodePacked(reason1, " OR ", reason2)
+        );
+        assertWithMsg(isEqual, assertMsg);
     }
 
     function assertRevertReasonEqual(
@@ -343,7 +346,10 @@ abstract contract AssertHelper {
         bool isEqual = FuzzLibString.isRevertReasonEqual(returnData, reason1) ||
             FuzzLibString.isRevertReasonEqual(returnData, reason2) ||
             FuzzLibString.isRevertReasonEqual(returnData, reason3);
-        assertWithMsg(isEqual, string.concat(reason1, " OR ", reason2, " OR ", reason3));
+        string memory assertMsg = string(
+            abi.encodePacked(reason1, " OR ", reason2, " OR ", reason3)
+        );
+        assertWithMsg(isEqual, assertMsg);
     }
 
     function assertRevertReasonEqual(
@@ -357,9 +363,8 @@ abstract contract AssertHelper {
             FuzzLibString.isRevertReasonEqual(returnData, reason2) ||
             FuzzLibString.isRevertReasonEqual(returnData, reason3) ||
             FuzzLibString.isRevertReasonEqual(returnData, reason4);
-        assertWithMsg(
-            isEqual,
-            string.concat(
+        string memory assertMsg = string(
+            abi.encodePacked(
                 reason1,
                 " OR ",
                 reason2,