pmda/rds: move RDS domain number to fill empty slots#2535
Merged
kmcdonell merged 1 commit intoperformancecopilot:mainfrom Mar 21, 2026
Merged
pmda/rds: move RDS domain number to fill empty slots#2535kmcdonell merged 1 commit intoperformancecopilot:mainfrom
kmcdonell merged 1 commit intoperformancecopilot:mainfrom
Conversation
Signed-off-by: Pradyumn Rahar <pradyumn.rahar@oracle.com>
kmcdonell
approved these changes
Mar 21, 2026
Member
kmcdonell
left a comment
kmcdonell
left a comment
There was a problem hiding this comment.
This all looks good to me.
But in a future commit you may wish to consider.
- removing domain.h ... the PMDA build and Install infrastructure can create domain.h from the RDS entry in stdpmid.pcp
- then the Install script can extract the domain number from domain.h
- the pmns file can use RDS instead of 37 ... the Install script automagically rewrites this
The simple PMDA has examples for all of the above.
With changes, you would only have needed to make the stdpmid.pcp and pmdards.python change 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.