Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥Remove implicit controllers #83

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Conversation

Robdel12
Copy link
Contributor

What is this?

When integrating with the example app, it appears the implicit controller will never work. In order to call client functions / eval outside of test, you have to pass an instance of the controller.

eval cannot implicitly resolve the test run in context of which it should be executed. 
If you need to call eval from the Node.js API callback, pass the test controller manually via eval’s .with({ boundTestRun: t }) method first. 
*Note that you cannot execute eval outside the test code*

Knowing that, we have to drop that feature. Thankfully it only ever lived on the beta channels (and didn't work anyways). Along those lines, we have to use ClientFunction because eval is only available inside of test. (ClientFunction is what eval uses anyways).

@Robdel12 Robdel12 requested a review from wwilsman March 12, 2021 19:38
@Robdel12 Robdel12 added 🐛 bug Something isn't working ✨ enhancement New feature or request and removed 🐛 bug Something isn't working labels Mar 12, 2021
index.js Outdated Show resolved Hide resolved
@Robdel12 Robdel12 requested a review from wwilsman March 12, 2021 20:51
Copy link
Contributor

@wwilsman wwilsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎮

@Robdel12 Robdel12 force-pushed the rd/remove-implicit-controller branch from 02a8000 to 9476a19 Compare March 12, 2021 20:55
@Robdel12 Robdel12 merged commit aebc28f into master Mar 12, 2021
@Robdel12 Robdel12 deleted the rd/remove-implicit-controller branch March 12, 2021 20:59
@wwilsman wwilsman changed the title 💥Remove implicit controllers & use ClientFunction over eval 💥Remove implicit controllers Mar 12, 2021
Robdel12 added a commit that referenced this pull request Mar 12, 2021
* 💥Remove implicit controllers & use `ClientFunction` over eval

* 📝 Update README

* ♻️Use `eval` (with passing the `t` controller)

* ♻️Update missing test controller argument error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants