This repository was archived by the owner on Feb 12, 2022. It is now read-only.
fix: Give PercyScript its own user agent #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does duplicate most of the puppeteer SDK, but that's okay. Every other SDK uses the same exact pattern for extracting the DOM from the test browser and then `POST`'ing that back to the agent process. I don't think we're actually DRYing anything up.
Robdel12
commented
Sep 12, 2019
wwilsman
approved these changes
Sep 12, 2019
wwilsman
left a comment
wwilsman
left a comment
There was a problem hiding this comment.
Only comments are around let/var
Feel free to ignore if you disagree since they're just nits
|
RE: fix vs. feat, I'd consider this a bug if it didn't report properly. So probably |
Robdel12
changed the title
Robdel12
added a commit
that referenced
this pull request
Sep 12, 2019
* Give PercyScript its own user agent This does duplicate most of the puppeteer SDK, but that's okay. Every other SDK uses the same exact pattern for extracting the DOM from the test browser and then `POST`'ing that back to the agent process. I don't think we're actually DRYing anything up. * Update CI scripts with yarn * Fix puppeteer var name typo * Code review feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
We're finally going to be able to spot when someone is using PercyScript (rather than it always showing as the Puppeteer SDK).
This does duplicate most of the puppeteer SDK, but that's okay. Every other SDK uses the same exact pattern for extracting the DOM from the test browser and then
POST'ing that back to the agent process. I don't think we're actually DRYing anything up.TODO:
fix:vsfeat: