This repository was archived by the owner on Feb 12, 2022. It is now read-only.
fix: Exit non-zero when catching error #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the script silently returned success when the running has failed. Workflows that relied on PR integration with Percy had received a failure from Percy, but independent workflows would silently pass until anyone notices a failure.
This will allow us swallow nodes uncaught promise rejection errors, print a nice stack trace, and also exit the script with a non-zero exit code.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Building slightly on top of #10, this still catches the error (to remove the node uncaught promise errors) and then exits the script (rather than still creating a passing build in CI). This results in much cleaner stack traces: