Skip to content

Capturing blob images support #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Capturing blob images support #1966

wants to merge 1 commit into from

Conversation

shantanuk-browserstack
Copy link
Contributor

No description provided.

@shantanuk-browserstack shantanuk-browserstack changed the title capturing blob images support Capturing blob images support Aug 21, 2025
@shantanuk-browserstack shantanuk-browserstack added the ✨ enhancement New feature or request label Aug 21, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 21, 2025
View reviewed changes
packages/dom/test/dynamic-resources.test.js
Comment on lines +35 to +38
document.body.innerHTML = `
<a href="${blobUrl}">Download</a>
<link href="${blobUrl}" rel="stylesheet">
`;

Check failure

Code scanning / Semgrep OSS

Semgrep Finding: javascript.browser.security.insecure-document-method.insecure-document-method Error test

User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities
packages/dom/test/dynamic-resources.test.js
Comment on lines +121 to +124
document.body.innerHTML = `
<img src="${blobUrl}" alt="blob image">
<video src="${blobUrl}"></video>
`;

Check failure

Code scanning / Semgrep OSS

Semgrep Finding: javascript.browser.security.insecure-document-method.insecure-document-method Error test

User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities
packages/dom/test/dynamic-resources.test.js
Comment on lines +159 to +161
document.body.innerHTML = `
<div style="background-image: url('${blobUrl}')">Test div</div>
`;

Check failure

Code scanning / Semgrep OSS

Semgrep Finding: javascript.browser.security.insecure-document-method.insecure-document-method Error test

User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities
packages/dom/test/dynamic-resources.test.js
canvas.toBlob(blob => {
const blobUrl = URL.createObjectURL(blob);

document.body.innerHTML = `<img src="${blobUrl}" alt="blob">`;

Check failure

Code scanning / Semgrep OSS

Semgrep Finding: javascript.browser.security.insecure-document-method.insecure-document-method Error test

User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities
packages/dom/test/dynamic-resources.test.js
canvas.height = 1;
canvas.toBlob(blob => {
const blobUrl = URL.createObjectURL(blob);
document.body.innerHTML = `<img src="${blobUrl}" alt="test">`;

Check failure

Code scanning / Semgrep OSS

Semgrep Finding: javascript.browser.security.insecure-document-method.insecure-document-method Error test

User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities
packages/dom/test/dynamic-resources.test.js
canvas.height = 1;
canvas.toBlob(blob => {
const blobUrl = URL.createObjectURL(blob);
document.body.innerHTML = `<img src="${blobUrl}" alt="test">`;

Check failure

Code scanning / Semgrep OSS

Semgrep Finding: javascript.browser.security.insecure-document-method.insecure-document-method Error test

User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities
packages/dom/test/dynamic-resources.test.js
canvas.height = 1;
canvas.toBlob(blob => {
const blobUrl = URL.createObjectURL(blob);
document.body.innerHTML = `<img src="${blobUrl}" alt="test">`;

Check failure

Code scanning / Semgrep OSS

Semgrep Finding: javascript.browser.security.insecure-document-method.insecure-document-method Error test

User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities
packages/dom/test/dynamic-resources.test.js
Comment on lines +519 to +521
document.body.innerHTML = `
<div style="background-image: url('${blobUrl1}'), url('${blobUrl2}')">Test</div>
`;

Check failure

Code scanning / Semgrep OSS

Semgrep Finding: javascript.browser.security.insecure-document-method.insecure-document-method Error test

User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shantanuk-browserstack