✨ DOM events triggered on clone fixed #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarsault
changed the title
itsjwala
reviewed
Feb 15, 2023
itsjwala
reviewed
Feb 15, 2023
itsjwala
reviewed
Feb 15, 2023
samarsault
commented
Feb 16, 2023
itsjwala
force-pushed
the
dom-events-fix
branch
from
627fef7 to
46c4294
Compare
itsjwala
changed the title
itsjwala
changed the title
itsjwala
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
In #1165, we refactored our DOM cloning logic. We moved to creating a clone and adding it to a cloned node of document. This, however triggers DOM events like connectedCallback which mess up the user DOM. This PR moves from keeping the clone node in a document to a
DocumentFragment