Skip to content

Commit

Permalink
Rename reported log_msg struct to log_msg_t
Browse files Browse the repository at this point in the history
MySQL defines a macro log_msg in one of its headers, which
causes log_msg to be replaced with different symbol in
some compilation units.

Fix by renaming the struct to log_msg_t to avoid the conflict.
  • Loading branch information
temeo committed Mar 19, 2024
1 parent 6a17207 commit 7d108eb
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
16 changes: 8 additions & 8 deletions include/wsrep/reporter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -105,21 +105,21 @@ namespace wsrep
typedef struct {
double tstamp;
std::string msg;
} log_msg;
} log_msg_t ;

std::deque<log_msg> err_msg_;
std::deque<log_msg> warn_msg_;
std::deque<log_msg> events_;
std::deque<log_msg_t> err_msg_;
std::deque<log_msg_t> warn_msg_;
std::deque<log_msg_t> events_;
size_t const max_msg_;

static void write_log_msg(std::ostream& os,
const log_msg& msg);
const log_msg_t& msg);
static void write_event(std::ostream& os,
const log_msg& msg);
const log_msg_t& msg);
static void write_array(std::ostream& os, const std::string& label,
const std::deque<log_msg>& events,
const std::deque<log_msg_t>& events,
void (*element_writer)(std::ostream& os,
const log_msg& msg));
const log_msg_t& msg));
substates substate_map(enum server_state::state state);
float progress_map(float progress) const;
void write_file(double timestamp);
Expand Down
12 changes: 6 additions & 6 deletions src/reporter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ static std::string escape_json(const std::string& str)

void
wsrep::reporter::write_log_msg(std::ostream& os,
const log_msg& msg)
const log_msg_t& msg)
{
os << "\t\t{\n";
os << "\t\t\t\"timestamp\": " << std::showpoint << std::setprecision(18)
Expand All @@ -187,7 +187,7 @@ wsrep::reporter::write_log_msg(std::ostream& os,

void
wsrep::reporter::write_event(std::ostream& os,
const log_msg& msg)
const log_msg_t& msg)
{
os << "\t\t{\n";
os << "\t\t\t\"timestamp\": " << std::showpoint << std::setprecision(18)
Expand All @@ -199,9 +199,9 @@ wsrep::reporter::write_event(std::ostream& os,
void
wsrep::reporter::write_array(std::ostream& os,
const std::string& label,
const std::deque<log_msg>& msgs,
const std::deque<log_msg_t>& msgs,
void (*element_writer)(std::ostream& os,
const log_msg& msg))
const log_msg_t& msg))
{
os << "\t\"" << label << "\": [\n";
for (size_t i(0); i < msgs.size(); ++i)
Expand Down Expand Up @@ -351,7 +351,7 @@ wsrep::reporter::report_log_msg(log_level const lvl,
const std::string& msg,
double tstamp)
{
std::deque<log_msg>& deque(lvl == error ? err_msg_ : warn_msg_);
std::deque<log_msg_t>& deque(lvl == error ? err_msg_ : warn_msg_);

wsrep::unique_lock<wsrep::mutex> lock(mutex_);

Expand All @@ -363,7 +363,7 @@ wsrep::reporter::report_log_msg(log_level const lvl,

/* Log messages are not expected to be json formatted, so we escape
the message strings here to keep the report file well formatted. */
log_msg entry({tstamp, escape_json(msg)});
log_msg_t entry({tstamp, escape_json(msg)});
deque.push_back(entry);
write_file(tstamp);
}
Expand Down

0 comments on commit 7d108eb

Please sign in to comment.