Skip to content

Fixed issues when removing FK and other fixes #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elchinoo
Copy link
Contributor

Fixed issue when removing FK. The function wasn't checking if the FK was present in the new table and was trying to remove it from the table throwing an error.
Added a new check when using '--alter-foreign-keys-method=drop_swap'. When using the drop_swap method the tool set 'drop-old-table' to false and the method 'after_drop_old_table' is not called.
Added a simple test suit which is far from complete or ideal but helps with repetitive tasks. This is intended to be replace in the future for a real test suit

…was present in the new table and was trying to remove it from the table throwing an error.

Added a new check when using '--alter-foreign-keys-method=drop_swap'. When using the drop_swap method the tool set 'drop-old-table' to false and the method 'after_drop_old_table' is not called.
Added a simple test suit which is far from complete or ideal but helps with repetitive tasks. This is intended to be replace in the future for a real test suit
@elchinoo elchinoo merged commit 3831651 into percona:ptosc_plugin_rename_fk Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants