add docker multistage build #58
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
denisok
requested review from
a team,
askomorokhov and
percona-csalguero
and removed request for
a team
maksim-paskal
force-pushed
the
docker-multistage-build
branch
from
a873a10 to
7af5625
Compare
askomorokhov
previously approved these changes
Jun 29, 2021
percona-csalguero
previously approved these changes
Jun 29, 2021
|
@askomorokhov @percona-csalguero - CI is broken - do I need some changes in my PR? |
Signed-off-by: Maksim Paskal <paskal.maksim@gmail.com>
maksim-paskal
dismissed stale reviews from percona-csalguero and askomorokhov
via
f5cfc2e
maksim-paskal
force-pushed
the
docker-multistage-build
branch
from
bf2afb6 to
f5cfc2e
Compare
|
rebased to latest |
|
@askomorokhov we have this issue with secrets from forks... could you please test this one from your branch probably and land ? |
|
@maksim-paskal, thank you for your contribution! |
denisok
added
the
award
|
@maksim-paskal Hello! We would love to send you a gift from Percona for your contribution. Please, contact us at community-team@percona.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users without installed
gobinnary - can not build this docker image. This PR only add multi-stage feature to build this docker image.This change do not change any application logic