Prepare a new release. #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BupycHuk
reviewed
Jun 1, 2020
CHANGELOG.md
Outdated
| - `disable_basic_metrics` and `disable_enhanced_metrics` configuration options. | ||
|
|
||
| ### Changed | ||
| - Major changes in `node_exporter`-like metrics. |
There was a problem hiding this comment.
I think it's good to add a link what's changed in these metrics(naming and e.t.c.)
There was a problem hiding this comment.
Sure, what link should be used there?
There was a problem hiding this comment.
Maybe description from this PR #33?
AlekSi
commented
Jun 1, 2020
CHANGELOG.md
Outdated
| - `disable_basic_metrics` and `disable_enhanced_metrics` configuration options. | ||
|
|
||
| ### Changed | ||
| - Major changes in `node_exporter`-like metrics. See [here](https://github.com/percona/rds_exporter#metrics). |
There was a problem hiding this comment.
I think that's the best we can do here.
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=======================================
Coverage 81.91% 81.91%
=======================================
Files 9 9
Lines 752 752
=======================================
Hits 616 616
Misses 118 118
Partials 18 18
Continue to review full report at Codecov.
|
BupycHuk
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.