PMM-5085 Last tweaks. #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Dec 18, 2019
golangcibot
reviewed
Dec 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=========================================
Coverage ? 81.64%
=========================================
Files ? 9
Lines ? 741
Branches ? 0
=========================================
Hits ? 605
Misses ? 118
Partials ? 18
Continue to review full report at Codecov.
|
golangcibot
reviewed
Dec 18, 2019
| VSS int `json:"vss" help:"The amount of virtual memory allocated to the process, in kilobytes."` | ||
|
|
||
| // TODO Handle this. | ||
| // TODO Handle this: https://jira.percona.com/browse/PMM-5150 |
There was a problem hiding this comment.
enhanced/metrics.go:140: Line contains TODO/BUG/FIXME: "TODO Handle this: https://jira.percona.c..." (from godox)
| float64(m.Timestamp.Unix()), | ||
| )) | ||
|
|
||
| // TODO Parse uptime: https://jira.percona.com/browse/PMM-2131 |
There was a problem hiding this comment.
enhanced/metrics.go:469: Line contains TODO/BUG/FIXME: "TODO Parse uptime: https://jira.percona...." (from godox)
adivinho
approved these changes
Dec 18, 2019
BupycHuk
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed metrics:
node_boot_time=>node_boot_time_secondsnode_filesystem_free=>node_filesystem_free_bytesnode_memory_Cached=>node_memory_Cached_bytes