Skip to content

Conversation

@Andriciuc
Copy link
Collaborator

@Andriciuc Andriciuc commented May 15, 2025

initial commit, fixes to code presentation

  • Updates to kmip with fixes to how we present code (website looks better now!)
  • Updates set-principal-key with similar fixes
  • Updated keyring.md with similar fixes

And updated functions for two parameters with updates from 1506

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (2dbb8d8) to head (b83b3cd).

❌ Your project status has failed because the head coverage (80.49%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           TDE_REL_17_STABLE     #337      +/-   ##
=====================================================
- Coverage              80.50%   80.49%   -0.01%     
=====================================================
  Files                     22       22              
  Lines                   2606     2605       -1     
  Branches                 399      398       -1     
=====================================================
- Hits                    2098     2097       -1     
  Misses                   430      430              
  Partials                  78       78              
Components Coverage Δ
access 82.95% <ø> (ø)
catalog 87.55% <ø> (ø)
common 91.80% <ø> (ø)
encryption 75.70% <ø> (ø)
keyring 72.00% <ø> (ø)
src 66.74% <ø> (ø)
smgr 97.27% <ø> (-0.03%) ⬇️
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Cleaned sql code for easier readability and removed some highlighting errors
Fixed parameter text from PG-1506
@nastena1606 nastena1606 temporarily deployed to docs-kmip-clean - pg-tde-docs PR #337 May 16, 2025 06:45 — with Render Destroyed
@nastena1606 nastena1606 temporarily deployed to docs-kmip-clean - INTERNAL-pg_tde docs PR #337 May 16, 2025 06:46 — with Render Destroyed
@Andriciuc Andriciuc marked this pull request as ready for review May 16, 2025 06:58
@Andriciuc Andriciuc requested a review from nastena1606 as a code owner May 16, 2025 06:58
@Andriciuc Andriciuc merged commit 2ca6bb5 into TDE_REL_17_STABLE May 16, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants