Skip to content

PMM-9632 Settings view usage. #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

PMM-9632 Settings view usage. #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
14af14a
PMM-9632 Gen.
May 4, 2022
ef6c0ee
PMM-9632 Changes.
May 4, 2022
97cfc10
PMM-9632 Empty line.
May 4, 2022
7841a15
PMM-9632 Changes.
May 4, 2022
4c5b747
PMM-9632 Changes.
May 5, 2022
83c7926
PMM-9632 Changes.
May 5, 2022
94c4ed2
PMM-9632 Changes.
May 5, 2022
0466764
PMM-9632 Change data type.
May 5, 2022
f05ed97
Merge branch 'main' into PMM-9632-settings-view
May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
263 changes: 204 additions & 59 deletions api/agentpb/collector.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 14 additions & 0 deletions api/agentpb/collector.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ message MetricsBucket {
string planid = 46;
string query_plan = 48;
repeated HistogramItem histogram_items = 49;
repeated SettingsItem settings_items = 50;
}
Common common = 1;
MySQL mysql = 2;
Expand All @@ -359,3 +360,16 @@ message HistogramItem {
string range = 1;
uint32 frequency = 2;
}

// SettingsItem represents one row in settings.
message SettingsItem {
string name = 1;
string value = 2;
string default_value = 3;
string description = 4;
int64 minimum = 5;
int64 maximum = 6;
string options = 7;
string restart = 8;
}

10 changes: 10 additions & 0 deletions api/agentpb/collector.validator.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

68 changes: 39 additions & 29 deletions api/qanpb/collector.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions api/qanpb/collector.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,7 @@ message MetricsBucket {
string planid = 249;
string query_plan = 251;
repeated string histogram_items = 252;
repeated string settings_items = 253;
}

message CollectResponse {}
144 changes: 144 additions & 0 deletions api/qanpb/json/client/object_details/get_p_g_s_m_settings_parameters.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading