PMM-14616 list running api #4829
Open
+1,301
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced the RealtimeAnalyticsService with methods to list currently running RTA agents. - Added necessary proto files for gRPC and RESTful API integration. - Implemented validation logic for request and response messages. - Created service logic to handle agent data retrieval and filtering by cluster. - Added unit tests to ensure functionality and correctness of the service methods.
BupycHuk
requested review from
ademidoff and
maxkondr
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## PMM-14567 #4829 +/- ##
=============================================
- Coverage 45.93% 45.91% -0.02%
=============================================
Files 364 364
Lines 37834 37839 +5
=============================================
- Hits 17378 17375 -3
- Misses 18784 18788 +4
- Partials 1672 1676 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Updated PMM Server and MongoDB images in GitHub Actions workflows to specific versions. - Enhanced the Realtime Analytics service by modifying the ListRunningRealtimeAgents method signature for clarity. - Changed test assertions to use require.Empty for better readability.
- Changed the initialization of the Agents slice in the ListRunningRealtimeAgents method from using make to a shorthand slice literal for improved readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-14616
Link to the Feature Build: SUBMODULES-0
If this PR adds, removes or alters one or more API endpoints, please review and add or update the relevant API documentation as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: