This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
PMM-8884 PMM doesn't get MySQL and PostgreSQL metrics after upgrade. #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #838 +/- ##
=======================================
Coverage 50.06% 50.07%
=======================================
Files 169 169
Lines 19282 19287 +5
=======================================
+ Hits 9654 9657 +3
- Misses 8541 8543 +2
Partials 1087 1087
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
BupycHuk
reviewed
Oct 4, 2021
services/agents/agents_test.go
Outdated
| left := "{{" | ||
| right := "}}" | ||
| assert.Equal(t, "/usr/local/percona/pmm2", pathsBase("2.22.99", left, right)) | ||
| assert.Equal(t, "{{ .paths_base }}", pathsBase("2.23.00", left, right)) |
There was a problem hiding this comment.
what about developer versions and RCs?
BupycHuk
approved these changes
Oct 4, 2021
jprukner
approved these changes
Oct 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-8884
Build: PMM-8884 PMM doesn't get MySQL and PostgreSQL metrics after upgrade. Percona-Lab/pmm-submodules#2061
Links to other linked pull requests (optional).