Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

PMM-8673 MongoDB logs #822

Merged
merged 24 commits into from
Oct 5, 2021
Merged

PMM-8673 MongoDB logs #822

merged 24 commits into from
Oct 5, 2021

Conversation

Dasio
Copy link
Contributor

@Dasio Dasio commented Sep 8, 2021 •
edited
Loading

@Dasio Dasio self-assigned this Sep 8, 2021
github-actions[bot]
github-actions bot reviewed Sep 8, 2021
View reviewed changes
services/agents/jobs.go Show resolved Hide resolved
services/agents/jobs.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 8, 2021 •
edited
Loading

Codecov Report

Merging #822 (1d435d9) into main (dff7023) will decrease coverage by 0.09%.
The diff coverage is 68.53%.

❗ Current head 1d435d9 differs from pull request most recent head f98326e. Consider uploading reports for the commit f98326e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
- Coverage   50.07%   49.97%   -0.10%     
==========================================
  Files         169      169              
  Lines       19287    19424     +137     
==========================================
+ Hits         9657     9708      +51     
- Misses       8543     8628      +85     
- Partials     1087     1088       +1
Flag Coverage Δ
all 49.97% <68.53%> (+0.30%) ⬆️
cover 50.06% <64.33%> (+0.56%) ⬆️
crosscover 49.97% <68.53%> (-0.10%) ⬇️
update ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
models/database.go 64.00% <ø> (ø)
models/job_models.go 68.75% <ø> (+31.25%) ⬆️
services/agents/handler.go 0.00% <0.00%> (ø)
services/agents/jobs.go 0.00% <0.00%> (ø)
services/management/backup/backups_service.go 53.43% <56.41%> (+1.90%) ⬆️
models/job_models_reform.go 73.91% <79.41%> (+22.06%) ⬆️
models/job_helpers.go 78.26% <89.09%> (+37.72%) ⬆️
services/supervisord/supervisord.go 40.21% <0.00%> (-27.05%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff7023...f98326e. Read the comment docs.

artemgavrilov
artemgavrilov reviewed Sep 14, 2021
View reviewed changes
models/database.go Outdated Show resolved Hide resolved
@Dasio Dasio mentioned this pull request Sep 14, 2021
Merged
@Dasio Dasio marked this pull request as ready for review September 14, 2021 15:01
artemgavrilov
artemgavrilov reviewed Sep 16, 2021
View reviewed changes
models/job_helpers.go Outdated Show resolved Hide resolved
models/job_helpers_test.go Outdated Show resolved Hide resolved
models/job_helpers_test.go Outdated Show resolved Hide resolved
models/job_models.go Outdated Show resolved Hide resolved
services/management/backup/backups_service.go Outdated Show resolved Hide resolved
services/management/backup/backups_service.go Outdated Show resolved Hide resolved
services/management/backup/backups_service.go Show resolved Hide resolved
@artemgavrilov artemgavrilov assigned artemgavrilov and unassigned Dasio Sep 23, 2021
@artemgavrilov artemgavrilov mentioned this pull request Sep 27, 2021
Merged
2 tasks
oter
oter approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@oter oter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides minor comments

models/job_helpers_test.go Outdated Show resolved Hide resolved
services/agents/jobs.go Show resolved Hide resolved
services/management/backup/backups_service.go
return nil, status.Error(codes.NotFound, "Job related to artifact was not found.")
}
if len(jobs) > 1 {
s.l.Warnf("artifact %s appear in more than one job", req.ArtifactId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that possible? Probably we could error here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is possible. For PITR we have one artifact, but multiple jobs.

@artemgavrilov artemgavrilov mentioned this pull request Oct 1, 2021
Closed
@artemgavrilov artemgavrilov enabled auto-merge (squash) October 5, 2021 10:40
@artemgavrilov artemgavrilov merged commit 6d7fb6c into main Oct 5, 2021
@artemgavrilov artemgavrilov deleted the PMM-8673-mongodb-logs branch October 5, 2021 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@artemgavrilov artemgavrilov artemgavrilov approved these changes

@oter oter oter approved these changes

@BupycHuk BupycHuk BupycHuk approved these changes

Assignees

@artemgavrilov artemgavrilov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dasio @BupycHuk @oter @artemgavrilov