Skip to content

Fix integer overflow#435

Merged
artemgavrilov merged 9 commits intomainfrom
fix-integer-overflows
Apr 5, 2024
Merged

Fix integer overflow#435
artemgavrilov merged 9 commits intomainfrom
fix-integer-overflows

Conversation

@artemgavrilov
Copy link
Copy Markdown
Contributor

@artemgavrilov artemgavrilov commented Jan 30, 2024

Fixes #412

This PR fixes 3 integer overflow bugs, all of them covered with tests.

@it-percona-cla
Copy link
Copy Markdown

it-percona-cla commented Jan 30, 2024

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.55%. Comparing base (3d84610) to head (b0c05ec).
Report is 1 commits behind head on main.

Files Patch % Lines
pg_stat_monitor.c 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   90.55%   90.55%           
=======================================
  Files           3        3           
  Lines        1271     1271           
  Branches       35       35           
=======================================
  Hits         1151     1151           
  Misses         98       98           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artemgavrilov artemgavrilov changed the title [WIP] Fix integer overflows Fix integer overflow Feb 1, 2024
@artemgavrilov artemgavrilov marked this pull request as ready for review February 2, 2024 10:45
Copy link
Copy Markdown
Contributor

@Naeem-Akhter Naeem-Akhter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Naeem-Akhter
Copy link
Copy Markdown
Contributor

@codeforall @hqakhtar @dutow @dAdAbird

Can one of your please review c code files changes in this PR?

@artemgavrilov artemgavrilov merged commit 64c71f9 into main Apr 5, 2024
@artemgavrilov artemgavrilov deleted the fix-integer-overflows branch April 5, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DB does not start after setting pgsm_max to its maximum

4 participants