PS-10131 [8.4] Fix Audit Log file rotation stall #5708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-nowakowski-percona
force-pushed
the
PS-10131-8.4-fix-audit-log-rotation-stall
branch
from
60ad5f2 to
99d7541
Compare
jakub-nowakowski-percona
removed the request for review
from percona-ysorokin
https://perconadev.atlassian.net/browse/PS-10131 When using Audit Log in memory-buffered mode (ASYNCHRONOUS or PERFORMANCE), rotating a log file could be stalled for up to 1 second because file flushing thread wasn't being signaled properly. This patch fixes that, and causes log files to be rotated immediately upon request. However, since audit log file names contain rotation timestamp with resolution of 1 second, it introduces a possibility of log files being overwritten when rotated multiple times a second. To avoid potential loss of audit log information, timestamp used in names of newly rotated log files will be appended with a sequence number, whenever a file name collision was to occur.
jakub-nowakowski-percona
force-pushed
the
PS-10131-8.4-fix-audit-log-rotation-stall
branch
from
99d7541 to
180e3c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-10131
When using Audit Log in memory-buffered mode (ASYNCHRONOUS or PERFORMANCE), rotating a log file could be stalled for up to 1 second because file flushing thread wasn't being signaled properly. This patch fixes that, and causes log files to be rotated immediately upon request. However, since audit log file names contain rotation timestamp with resolution of 1 second, it introduces a possibility of log files being overwritten when rotated multiple times a second. To avoid potential loss of audit log information, timestamp used in names of newly rotated log files will be appended with a sequence number, whenever a file name collision was to occur.