K8SPSMDB-1635 configure through cr the auth mechanism for PMM#2342
Open
gkech wants to merge 5 commits into
Open
K8SPSMDB-1635 configure through cr the auth mechanism for PMM#2342gkech wants to merge 5 commits into
gkech wants to merge 5 commits into
Conversation
gkech
commented
May 20, 2026
| pmmServerArgs += "--service-name=$(PMM_AGENT_SETUP_NODE_NAME) --host=$(DB_HOST) --port=$(DB_PORT)" | ||
|
|
||
| if cr.TLSEnabled() { | ||
| authMechanism := defaultAuthMechanism |
Contributor
Author
There was a problem hiding this comment.
discuss if we want to continue using SCRAM-SHA-1 auth mechanism as the default one.
egegunes
reviewed
May 21, 2026
| ) | ||
|
|
||
| const ( | ||
| defaultAuthMechanism = "SCRAM-SHA-1" |
Contributor
There was a problem hiding this comment.
should we consider making 256 the default?
Contributor
There was a problem hiding this comment.
maybe we can ask PMM team to see if there are any possible side effects
Collaborator
commit: 8887205 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
The Percona operator v1.22.0 hardcodes --authentication-mechanism=SCRAM-SHA-1 when it launches the PMM exporter sidecar. The operator should allow configuring this option through a new cr configuration. For example:
Helm Chart PR: percona/percona-helm-charts#856
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability