Skip to content

Allow override to db URI in tests #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2018
Merged

Allow override to db URI in tests #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f06d49
Allow the test db uri to be overridded
timvaillancourt Jul 11, 2018
7b6557b
var name cleanup
timvaillancourt Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions internal/oplog/oplog_tail_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,14 @@ import (

const (
MaxBSONSize = 16 * 1024 * 1024 // 16MB - maximum BSON document size
EnvDBUri = "TEST_MONGODB_URI"
)

var (
keepSamples bool
samplesDir string
dbUri string
dbDefaultUri string = "localhost:17001"
keepSamples bool
samplesDir string
)

func init() {
Expand All @@ -45,13 +48,19 @@ func init() {
samplesDir = path.Join(strings.TrimSpace(string(out)), "testdata")
}

// get db uri from environment if it exists
dbUri := strings.TrimSpace(os.Getenv(EnvDBUri))
if dbUri == "" {
dbUri = dbDefaultUri
}

if testing.Verbose() {
fmt.Printf("Samples & helper binaries at %q\n", samplesDir)
}
}

func TestDetermineOplogCollectionName(t *testing.T) {
session, err := mgo.Dial("localhost:17001")
session, err := mgo.Dial(dbUri)
if err != nil {
t.Fatalf("Cannot connect to MongoDB: %s", err)
}
Expand All @@ -66,7 +75,7 @@ func TestDetermineOplogCollectionName(t *testing.T) {
}

func TestBasicReader(t *testing.T) {
session, err := mgo.Dial("localhost:17001")
session, err := mgo.Dial(dbUri)
ot, err := Open(session)
if err != nil {
t.Fatalf("Cannot instantiate the oplog tailer: %s", err)
Expand Down Expand Up @@ -106,7 +115,7 @@ func TestTailerCopy(t *testing.T) {
defer os.Remove(tmpfile.Name()) // clean up
}

session, err := mgo.Dial("localhost:17001")
session, err := mgo.Dial(dbUri)
// Start tailing the oplog
ot, err := Open(session)
if err != nil {
Expand All @@ -131,7 +140,7 @@ func TestTailerCopy(t *testing.T) {
}

func TestSeveralOplogDocTypes(t *testing.T) {
session, err := mgo.Dial("localhost:17001")
session, err := mgo.Dial(dbUri)
// Start tailing the oplog
defer session.Close()

Expand Down Expand Up @@ -211,7 +220,7 @@ func TestUploadOplogToS3(t *testing.T) {
bucket := "percona-mongodb-backup-test"
filename := "percona-mongodb-backup-oplog"

mdbSession, err := mgo.Dial("localhost:17001")
mdbSession, err := mgo.Dial(dbUri)
if err != nil {
t.Errorf("Cannot connect to MongoDB: %s", err)
t.Fail()
Expand Down