Clone *mgo.Session (and close it within goroutine) to fix error with go test -race #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under go test with -race the TestUploadOplogToS3 panics. This seems to be due to the session being used in a goroutine that .Open() starts.
Without this PR, you get this panic with go test -race:
After this PR I no longer get this error, but I'm not sure if the way I fixed this is ideal. @percona-csalguero: what do you think? It's also possible a 'defer' is triggering too early?
This change: