Skip to content

Remove 'snappy' from ServerCompressors, add 'none' type #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: it's no need to wait because all agents are not started at the same t…
merged 1 commit into from
Feb 9, 2019
Merged

Remove 'snappy' from ServerCompressors, add 'none' type #189

merged 1 commit into from
Feb 9, 2019

Conversation

@timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Feb 9, 2019 •
edited
Loading

  1. Remove 'snappy' from ServerCompressor 'help' message.
  2. Add 'none' to grpcCompressors slice so that compression can be disabled.

Before this change:

$ ./pbmctl --server-compressor=none list backups
FATA[0000] enum value must be one of gzip, got 'none'

@timvaillancourt timvaillancourt merged commit 1fcb5d5 into master Feb 9, 2019
@timvaillancourt timvaillancourt deleted the fix_server_compressor_help branch February 9, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@timvaillancourt