PBM-88 PBM-162 Added storage pkg #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new storage pkg and tests to handle different kinds of storages in PBM
- Added storage pkg - Modified client to use the storage - Updated tests - Fixed error in backup writer (missing close pipe upon finishing) - New reader pkg - Minio support
golangcibot
reviewed
Jan 23, 2019
| StorageName: bm.GetStorageName(), | ||
| } | ||
| source.Client.restoreBackup(msg) | ||
| source.Client.RestoreBackup(msg) |
There was a problem hiding this comment.
Error return value of source.Client.RestoreBackup is not checked (from errcheck)
| str := strings.Repeat("a", int(chunkSize)) | ||
| size := int64(0) | ||
| for { | ||
| bw.Write([]byte(str)) |
There was a problem hiding this comment.
Error return value of bw.Write is not checked (from errcheck)
| return | ||
| } | ||
| buf := make([]byte, 16*1024*1024) | ||
| br.bytesRead, err = io.CopyBuffer(pw, result.Body, buf) |
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
|
|
||
| rs1OplogFilename := fmt.Sprintf("%s_rs1.oplog", backupNamePrefix) | ||
| rs1LocalFilename := path.Join(os.TempDir(), rs1OplogFilename) | ||
| rs1File, err := os.Create(rs1LocalFilename) |
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
|
|
||
| rs2OplogFilename := fmt.Sprintf("%s_rs2.oplog", backupNamePrefix) | ||
| rs2LocalFilename := path.Join(os.TempDir(), rs2OplogFilename) | ||
| rs2File, err := os.Create(rs2LocalFilename) |
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
percona-csalguero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new storage pkg and tests to handle different kinds of storages
in PBM