Skip to content

PBM-104: Use gzip as default for backup #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2019
Merged

PBM-104: Use gzip as default for backup #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cli/pbmctl/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,17 +270,17 @@ func startBackup(ctx context.Context, apiClient pbapi.ApiClient, opts *cliOption
}

switch *opts.compressionAlgorithm {
case "":
case "none":
case "gzip":
msg.CompressionType = pbapi.CompressionType_COMPRESSION_TYPE_GZIP
default:
return fmt.Errorf("compression algorithm %q ins invalid", *opts.compressionAlgorithm)
return fmt.Errorf("compression algorithm %q is invalid", *opts.compressionAlgorithm)
}

switch *opts.encryptionAlgorithm {
case "":
default:
return fmt.Errorf("encryption is not implemente yet")
return fmt.Errorf("encryption is not implemented yet")
}

_, err := apiClient.RunBackup(ctx, msg)
Expand Down Expand Up @@ -327,7 +327,7 @@ func processCliArgs(args []string) (string, *cliOptions, error) {
backup: backupCmd,
backupType: backupCmd.Flag("backup-type", "Backup type (logical or hot)").Default("logical").Enum("logical", "hot"),
destinationType: backupCmd.Flag("destination-type", "Backup destination type (file or aws)").Default("file").Enum("file", "aws"),
compressionAlgorithm: backupCmd.Flag("compression-algorithm", "Compression algorithm used for the backup").String(),
compressionAlgorithm: backupCmd.Flag("compression-algorithm", "Compression algorithm used for the backup (gzip or none)").Default("gzip").Enum("none", "gzip"),
encryptionAlgorithm: backupCmd.Flag("encryption-algorithm", "Encryption algorithm used for the backup").String(),
description: backupCmd.Flag("description", "Backup description").Required().String(),

Expand Down