Add a 'start' tailer timestamp, stop passing collection to .tailQuery() #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with .OpenAt in internal/oplog/oplog_tail.go where it will start at the doc AFTER the provided time+counter instead of including the starting doc.
This change adds a 'start' bson.MongoTimestamp and the support for .tailQuery() to use that time using a "$gte" operation instead of "$gt" that the 'last' timestamp uses. This will also allow us to see the start and end time of the tailer.
Lastly, I removed passing the *mgo.Collection to .tailQuery() as this isn't used anymore.