Skip to content

prevent mongos router from returning mongodb_mongod_replset_my_state #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
+13 −13
Merged

prevent mongos router from returning mongodb_mongod_replset_my_state #1188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63c1f52
prevent mongos router from returning mongodb_mongod_replset_my_state
igroene Oct 29, 2025
a495595
chore: fix the compat version collector test
ademidoff Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions exporter/feature_compatibility_version_collector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,17 +50,19 @@ func TestFCVCollector(t *testing.T) {
var mversion string

mmv := fmt.Sprintf("%d.%d", v.Segments()[0], v.Segments()[1])
switch {
case mmv == "5.0":
switch mmv {
case "5.0":
mversion = "4.4"
case mmv == "4.4":
case "4.4":
mversion = "4.2"
case mmv == "6.0":
case "6.0":
mversion = "5.0"
case mmv == "7.0":
case "7.0":
mversion = "6.0"
case mmv == "8.0":
case "8.0":
mversion = "7.0"
case "8.2":
mversion = "8.0"
default:
mversion = mmv
}
Expand Down
12 changes: 5 additions & 7 deletions exporter/v1_compatibility.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,20 +819,18 @@
}
}

if nodeType != typeArbiter {
if nodeType == typeMongod {

Check failure on line 822 in exporter/v1_compatibility.go

View workflow job for this annotation

GitHub Actions / Lint Check 

`if nodeType == typeMongod` has complex nested blocks (complexity: 5) (nestif)
metrics = append(metrics, myState(ctx, client))
if replSetGetStatus, ok := m["replSetGetStatus"].(bson.M); ok {
if rm := replSetMetrics(replSetGetStatus, l); rm != nil {
metrics = append(metrics, rm...)
}
}

if nodeType != typeMongos {
if opLogMetrics, err := oplogStatus(ctx, client); err != nil {
l.Warn("cannot create metrics for oplog", "error", err)
} else {
metrics = append(metrics, opLogMetrics...)
}
if opLogMetrics, err := oplogStatus(ctx, client); err != nil {
l.Warn("cannot create metrics for oplog", "error", err)
} else {
metrics = append(metrics, opLogMetrics...)
}
}

Expand Down