Django 3 & reshape the repo #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 16057a7.
alyohea
reviewed
Jan 17, 2022
There was a problem hiding this comment.
Also i see warning in the py39-dj32 tests
HINT: Configure the DEFAULT_AUTO_FIELD setting or the AppConfig.default_auto_field attribute to point to a subclass of AutoField, e.g. 'django.db.models.BigAutoField'.
readonly_app.Bus: (models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'.
We can skip this or update settings configuration
https://docs.djangoproject.com/en/3.2/releases/3.2/#customizing-type-of-auto-created-primary-keys
added 11 commits
January 17, 2022 15:05
Fixed that in 35253dc |
|
@alyohea thanks for the comments ! I didn't see them before just now, and I was working on the app on my side and I believe I had independently found the same issues on my side :D Except the uniclde_literals, good catch. Well congratulations for a spot-on review, you caught all the important things :D |
|
Ready for review, all green ! |
mike-perdide
approved these changes
Jan 17, 2022
|
@alyohea Please be my guest and merge :) |
|
🎈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.