[MONDRIAN-2529] ChooseByVolume=true can fail due to integer overflow #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Completed❌ This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues. Build Commandsmvn -B -fn -DrunITs=true -f pom.xml clean install && mvn -B -f pom.xml siteCleanup Commandsmvn -B -f pom.xml build-helper:remove-project-artifactChanged files mondrian/src/it/java/mondrian/rolap/TestAggregationManager.java
mondrian/src/it/java/mondrian/rolap/agg/AggStarTest.java
mondrian/src/it/java/mondrian/test/BasicQueryTest.java
mondrian/src/main/java/mondrian/rolap/RolapStar.java
mondrian/src/main/java/mondrian/rolap/RolapStatisticsCache.java
mondrian/src/main/java/mondrian/rolap/aggmatcher/AggStar.java
mondrian/src/main/java/mondrian/rolap/aggmatcher/JdbcSchema.java
mondrian/src/main/java/mondrian/rolap/cache/SegmentCacheIndexImpl.java
mondrian/src/main/java/mondrian/spi/SegmentColumn.java
mondrian/src/main/java/mondrian/spi/StatisticsProvider.java
mondrian/src/main/java/mondrian/spi/impl/JdbcStatisticsProvider.java
mondrian/src/main/java/mondrian/spi/impl/SqlStatisticsProvider.javaStill Broken Tests:mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderNoWildcards:🔴 junit.framework.AssertionFailedError:
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_department=('Dairy')}
{product_class.product_family=('Drink')}
{time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Headermondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderThreeSegs:🔴 junit.framework.AssertionFailedError:
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_department=('Dairy')}
{product_class.product_family=('Drink')}
{time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Headermondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithData:🔴 junit.framework.AssertionFailedError:
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_department=('Dairy')}
{product_class.product_family=('Drink')}
{time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Headermondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithEmptySegmentBody:🔴 junit.framework.AssertionFailedError:
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{time_by_day.month_of_year=('2','3','4','5','6','7')}
{time_by_day.quarter=('Q1','Q2','Q3')}
{time_by_day.the_year=('1998')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[208c5162e6bb49ceb217eab3621f4fc0209f73265c291a3f8aa673aee775de81]
, *Segmentmondrian.rolap.CacheControlTest.testFlush:🔴 junit.framework.ComparisonFailure:
expected:<...7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_family=(*)}
{time_by_day.quarter=(*)}
{time_by_day.the_year=(*)}]
Excluded Regions:[]
Compound Predicates:[]
ID:[81b691ea51d52148d99bccac888d5eebc210cfd1a3424b4f59b2ad59323da286]
*Segment Header
Schema:[FoodMart]
Checksum:[7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_family=(*)}
mondrian.rolap.CacheControlTest.testMondrian1094:🔴 junit.framework.ComparisonFailure:
expected:<...7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{store.store_country=('USA')}
{time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[1491d28d8de0649874b1c13ef4f142406776a2ed46ad27fd21dff9e9306c75d7]
discard segment - it cannot be constrained and maintain consistency:
*Segment Header
Schema:[FoodMart]
Checksum:[7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
mondrian.rolap.CacheControlTest.testPartialFlush:🔴 junit.framework.ComparisonFailure:
expected:<...7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_family=(*)}
{time_by_day.quarter=(*)}
{time_by_day.the_year=(*)}]
Excluded Regions:[]
Compound Predicates:[]
ID:[81b691ea51d52148d99bccac888d5eebc210cfd1a3424b4f59b2ad59323da286]
*Segment Header
Schema:[FoodMart]
Checksum:[7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_family=(*)}
mondrian.rolap.CacheControlTest.testPartialFlush_2:🔴 junit.framework.ComparisonFailure:
expected:<...7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{customer.gender=('M')}
{time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[956eb6693e4890a305b086aab9fa5f3b33f541e8eb1321e2e4c5f01cff475fa4]
Cache state after flush:
*Segment Header
Schema:[FoodMart]
Checksum:[7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{customer.gender=('M')}
{time_by_day.the_year=mondrian.rolap.CacheControlTest.testPartialFlushRange:🔴 junit.framework.ComparisonFailure:
expected:<...7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_family=(*)}
{time_by_day.quarter=(*)}
{time_by_day.the_year=(*)}]
Excluded Regions:[]
Compound Predicates:[]
ID:[81b691ea51d52148d99bccac888d5eebc210cfd1a3424b4f59b2ad59323da286]
*Segment Header
Schema:[FoodMart]
Checksum:[7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_family=(*)}
Integration test coverage changeThese statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation. mondrian.olap.Util.SqlNullSafeComparator
mondrian.rolap.agg.SegmentCacheManager.AbortException
mondrian.rolap.agg.SegmentCacheManager.Actor
mondrian.rolap.agg.SegmentLoader
mondrian.rolap.agg.SegmentLoader.2.new SegmentCacheManager.Command() {...}
mondrian.rolap.aggmatcher.AggStar.FactTable
mondrian.rolap.aggmatcher.AggTableManager
mondrian.rolap.BatchLoader
mondrian.rolap.BatchLoader.Batch
mondrian.rolap.cache.SegmentCacheIndexImpl
mondrian.rolap.RolapStar
mondrian.rolap.RolapStar.Column
mondrian.rolap.RolapStatisticsCache
mondrian.server.MonitorImpl.Handler
mondrian.spi.impl.JdbcStatisticsProvider
mondrian.spi.impl.SqlStatisticsProvider
mondrian.util.CacheMap
mondrian.util.FilteredIterableList
License header violations
|
Build Completed🔥 This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues. Build Commandsmvn -B -fn -DrunITs=true -f pom.xml clean install && mvn -B -f pom.xml siteCleanup Commandsmvn -B -f pom.xml build-helper:remove-project-artifactChanged files mondrian/src/it/java/mondrian/rolap/TestAggregationManager.java
mondrian/src/it/java/mondrian/rolap/agg/AggStarTest.java
mondrian/src/it/java/mondrian/test/BasicQueryTest.java
mondrian/src/main/java/mondrian/rolap/RolapStar.java
mondrian/src/main/java/mondrian/rolap/RolapStatisticsCache.java
mondrian/src/main/java/mondrian/rolap/aggmatcher/AggStar.java
mondrian/src/main/java/mondrian/rolap/aggmatcher/JdbcSchema.java
mondrian/src/main/java/mondrian/rolap/cache/SegmentCacheIndexImpl.java
mondrian/src/main/java/mondrian/spi/SegmentColumn.java
mondrian/src/main/java/mondrian/spi/StatisticsProvider.java
mondrian/src/main/java/mondrian/spi/impl/JdbcStatisticsProvider.java
mondrian/src/main/java/mondrian/spi/impl/SqlStatisticsProvider.javaNewly Fixed Tests:mondrian.test.CompoundSlicerTest.testBugMondrian899:🔵 junit.framework.ComparisonFailure:
Expected:
Axis #0:
{[Time].[1997].[Q1].[2]}
{[Time].[1997].[Q1].[3]}
{[Time].[1997].[Q2].[4]}
{[Time].[1997].[Q2].[5]}
{[Time].[1997].[Q2].[6]}
{[Time].[1997].[Q3].[7]}
{[Time].[1997].[Q3].[8]}
{[Time].[1997].[Q3].[9]}
{[Time].[1997].[Q4].[10]}
{[Time].[1997].[Q4].[11]}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Spokane].[Wildon Cameron]}
{[Customers].[USA].[WA].[Spokane].[Emily Barela]}
{[Customers].[USA].[WA].[Spokane].[Dauna Bartonmondrian.test.CompoundSlicerTest.testCompoundAggCalcMemberInSlicer1:🔵 junit.framework.ComparisonFailure:
Compound aggregated member should return same results with native filter on/off expected:<...Janis Strunk]}
{[Customers].[USA].[OR].[Albany].[L. Albert Wall]}
{[Customers].[USA].[OR].[Albany].[Norman Arnold]}
{[Customers].[USA].[OR].[Albany].[Pauline Kubitschek]}
{[Customers].[USA].[OR].[Albany].[Peggy Denton]}
{[Customers].[USA].[OR].[Albany].[Roslyn Jasper]}
{[Customers].[USA].[OR].[Albany].[Tina Heidi]}
{[Customers].[USA].[OR].[Albany].[Veronica Sulkind]}
{mondrian.test.NamedSetTest.testHierarchizeNamedSetImmutable:🔵 junit.framework.ComparisonFailure:
Expected:
Axis #0:
{}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Yakima].[Tracy Meyer], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[Vanessa Thompson], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[Velma Lykes], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[William Battaglia], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[Wmondrian.test.NamedSetTest.testNamedSetRangeInSlicerPrimed:🔵 junit.framework.ComparisonFailure:
Expected:
Axis #0:
{[Time].[1997].[Q1].[2]}
{[Time].[1997].[Q1].[3]}
{[Time].[1997].[Q2].[4]}
{[Time].[1997].[Q2].[5]}
{[Time].[1997].[Q2].[6]}
{[Time].[1997].[Q3].[7]}
{[Time].[1997].[Q3].[8]}
{[Time].[1997].[Q3].[9]}
{[Time].[1997].[Q4].[10]}
{[Time].[1997].[Q4].[11]}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Spokane].[Wildon Cameron]}
{[Customers].[USA].[WA].[Spokane].[Emily Barela]}
{[Customers].[USA].[WA].[Spokane].[Dauna Bartonorg.olap4j.CellSetFormatterTest.testQuery1Traditional:🔵 java.lang.RuntimeException:
org.olap4j.OlapException: XMLA provider gave exception: <SOAP-ENV:Fault>
<faultcode>
SOAP-ENV:Server.00HSBE02
</faultcode>
<faultstring>
XMLA Discover unparse results error
</faultstring>
<faultactor>
Mondrian
</faultactor>
<detail>
<XA:error xmlns:XA="http://mondrian.sourceforge.net">
<code>
00HSBE02
</code>
<desc>
The Mondrian XML: Mondrian Error:Internal error: No server instance has id '$ff1VUZA22c0AAHEwBAouU8H2AStill Broken Tests:mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderNoWildcards:🔴 junit.framework.AssertionFailedError:
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_department=('Dairy')}
{product_class.product_family=('Drink')}
{time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Headermondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderThreeSegs:🔴 junit.framework.AssertionFailedError:
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_department=('Dairy')}
{product_class.product_family=('Drink')}
{time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Headermondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithData:🔴 junit.framework.AssertionFailedError:
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_department=('Dairy')}
{product_class.product_family=('Drink')}
{time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Headermondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithEmptySegmentBody:🔴 junit.framework.AssertionFailedError:
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{time_by_day.month_of_year=('2','3','4','5','6','7')}
{time_by_day.quarter=('Q1','Q2','Q3')}
{time_by_day.the_year=('1998')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[208c5162e6bb49ceb217eab3621f4fc0209f73265c291a3f8aa673aee775de81]
, *Segmentmondrian.rolap.CacheControlTest.testFlush:🔴 junit.framework.ComparisonFailure:
expected:<...7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_family=(*)}
{time_by_day.quarter=(*)}
{time_by_day.the_year=(*)}]
Excluded Regions:[]
Compound Predicates:[]
ID:[81b691ea51d52148d99bccac888d5eebc210cfd1a3424b4f59b2ad59323da286]
*Segment Header
Schema:[FoodMart]
Checksum:[7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_family=(*)}
mondrian.rolap.CacheControlTest.testMondrian1094:🔴 junit.framework.ComparisonFailure:
expected:<...7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{store.store_country=('USA')}
{time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[1491d28d8de0649874b1c13ef4f142406776a2ed46ad27fd21dff9e9306c75d7]
discard segment - it cannot be constrained and maintain consistency:
*Segment Header
Schema:[FoodMart]
Checksum:[7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
mondrian.rolap.CacheControlTest.testPartialFlush:🔴 junit.framework.ComparisonFailure:
expected:<...7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_family=(*)}
{time_by_day.quarter=(*)}
{time_by_day.the_year=(*)}]
Excluded Regions:[]
Compound Predicates:[]
ID:[81b691ea51d52148d99bccac888d5eebc210cfd1a3424b4f59b2ad59323da286]
*Segment Header
Schema:[FoodMart]
Checksum:[7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_family=(*)}
mondrian.rolap.CacheControlTest.testPartialFlush_2:🔴 junit.framework.ComparisonFailure:
expected:<...7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{customer.gender=('M')}
{time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[956eb6693e4890a305b086aab9fa5f3b33f541e8eb1321e2e4c5f01cff475fa4]
Cache state after flush:
*Segment Header
Schema:[FoodMart]
Checksum:[7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{customer.gender=('M')}
{time_by_day.the_year=mondrian.rolap.CacheControlTest.testPartialFlushRange:🔴 junit.framework.ComparisonFailure:
expected:<...7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_family=(*)}
{time_by_day.quarter=(*)}
{time_by_day.the_year=(*)}]
Excluded Regions:[]
Compound Predicates:[]
ID:[81b691ea51d52148d99bccac888d5eebc210cfd1a3424b4f59b2ad59323da286]
*Segment Header
Schema:[FoodMart]
Checksum:[7b4af973b0d21f364b0a746f5565cb03]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
{product_class.product_family=(*)}
Integration test coverage changeThese statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation. mondrian.olap.Util.Flat3List
mondrian.rolap.agg.SegmentCacheManager.AbortException
mondrian.rolap.agg.SegmentCacheManager.Actor
mondrian.rolap.agg.SegmentLoader
mondrian.rolap.agg.SegmentLoader.2.new SegmentCacheManager.Command() {...}
mondrian.rolap.aggmatcher.AggStar.FactTable
mondrian.rolap.aggmatcher.AggTableManager
mondrian.rolap.BatchLoader
mondrian.rolap.BatchLoader.Batch
mondrian.rolap.BatchLoader.BatchComparator
mondrian.rolap.cache.SegmentCacheIndexImpl
mondrian.rolap.RolapStar
mondrian.rolap.RolapStar.Column
mondrian.rolap.RolapStatisticsCache
mondrian.server.Execution
mondrian.server.MondrianServerRegistry
mondrian.spi.impl.JdbcStatisticsProvider
mondrian.spi.impl.SqlStatisticsProvider
mondrian.xmla.Rowset
mondrian.xmla.XmlaHandler
|
|
@mchen-len-son @mkambol @lucboudreau @kurtwalker please review |
|
@mchen-len-son @mkambol @lucboudreau @kurtwalker @pamval please review |
1 similar comment
|
@mchen-len-son @mkambol @lucboudreau @kurtwalker @pamval please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.