[MONDRIAN-2279] - When a query is cancelled or times out, Mondrian may continue iterating over large tuple lists #639
Conversation
| while (cursor.forward()) { | ||
| CancellationChecker.checkCancelOrTimeout( | ||
| currentIteration++, Locus.peek().execution); |
There was a problem hiding this comment.
Can you put Execution in a variable please? It will always be the same execution and will remove a few virtual function calls from each iteration, as this is a tight loop. (please apply this in all other instances)
YuryBY
force-pushed
the
MONDRIAN-2279
branch
2 times, most recently
from
50ae471 to
38a5554
Compare
|
@lucboudreau, @mkambol, PR is updated. Thanks. |
| @@ -1052,6 +1052,18 @@ setting it too high can cause a big delay between the query being marked as canc | |||
| <Default>10000</Default> | |||
| </PropertyDefinition> | |||
| <PropertyDefinition> | |||
| <Name>CheckCancelOrTimeoutInterval</Name> | |||
There was a problem hiding this comment.
Sorry I just saw this, but we already have another property, CancelPhaseInterval, which does the same. Please standardize on one of the two and make sure to replace all usages of the old property with your new code to handle cancelations as well.
…y continue iterating over large tuple lists
|
@lucboudreau, @mkambol, PR is ready. Thanks. |
[MONDRIAN-2279] - When a query is cancelled or times out, Mondrian may continue iterating over large tuple lists
|
@YuryBY @mkambol @lucboudreau This commit broke an Integration test in pentaho-analyzer, DrillBeanIT.testDrillContextDescription. Throws a NPE. CC @rfellows |
@lucboudreau, @mkambol, would you mind of reviewing/merging?