[MONDRIAN-1126] - tests demonstrate the issue isn't reproduced #620
Conversation
| TestContext context = getTestContext(); | ||
| String dateDim = | ||
| "<Dimension name='Date' type='TimeDimension'>\n" | ||
| + " <Hierarchy hasAll='false' primaryKey='time_id'>\n" |
There was a problem hiding this comment.
@YuryBY
You've added a [Date] dimension, but your query and test is still validating against the [Time] dimension. I'm guessing you intended to use the [Date] dim.
One other thing-- all these tests have a whole lot of overlap. Could you extract out some of the commonality so the tests are a bit more succinct?
YuryBY
force-pushed
the
MONDRIAN-1126
branch
from
b271bd3 to
1033547
Compare
|
@mkambol, the changes are done. Now tests with [Date] cover four scenarios with olap4j: -SsasCompatibleNaming is true & hasAll for hierarchy is true |
|
@mkambol, any updates? Thanks. |
|
@mkambol, year in header is changed to the current one |
| * </a> | ||
| */ | ||
| public void testNamesIdentitySsasCompatible() { | ||
| propSaver.set( |
There was a problem hiding this comment.
@YuryBY Running this test by itself will fail. The [Time.Weekly] reference you have below is not resolvable using SSAS compatible naming (which would use [Time].[Weekly].
I'm guessing this succeeds when running the full test class because there's a sequence issue with the property value not applied. Possibly the test is loading an already cached schema, which had the default properties set from an earlier test execution.
|
@mkambol, the PR is updated. Thanks. |
[MONDRIAN-1126] - tests demonstrate the issue isn't reproduced
@mkambol, could you please take a look?